Subscriptions: Implement Caching for Subscription Info #710
+98
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miasma13
approved these changes
Mar 11, 2024
afterxleep
added a commit
to duckduckgo/iOS
that referenced
this pull request
Mar 11, 2024
Task/Issue URL: https://app.asana.com/0/0/1206800657723184/f BSK PR: duckduckgo/BrowserServicesKit#710 Description: Bumps BSK to use subscription caching: Push Purchase Cancel update to Webview on user cancellation Minor presentation updates for sheets and subscription-related Settings cleanup Co-authored-by: Michal Smaga <[email protected]>
afterxleep
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Mar 11, 2024
Task/Issue URL: https://app.asana.com/0/0/1206800657723184/f BSK PR: duckduckgo/BrowserServicesKit#710 Description: Bumps BSK to use subscription caching and updates previously used cache in Settings Push canceled event to the Weview on user cancellation --------- Co-authored-by: Michal Smaga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1206800657723184/f
iOS PR: duckduckgo/iOS#2569
macOS PR: duckduckgo/macos-browser#2368
What kind of version bump will this require?: Minor
Description:
Steps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template