Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix safari file not found error handling #2242

Merged
merged 2 commits into from
Feb 26, 2024

Merge branch 'main' into alex/fix-safari-no-bookmarks-error

b947533
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

fix safari file not found error handling #2242

Merge branch 'main' into alex/fix-safari-no-bookmarks-error
b947533
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Report: Non-Sandbox failed Feb 26, 2024 in 0s

1405 tests run, 1402 passed, 0 skipped, 3 failed.

Annotations

Check failure on line 1 in DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Integration Tests.build/Objects-normal/arm64/ErrorPageTests.d

See this annotation in the file changed.

@github-actions github-actions / Test Report: Non-Sandbox

ErrorPageTests.testWhenGoingBackToFailingPage_reloadIsTriggered 

/Users/runner/work/macos-browser/macos-browser/IntegrationTests/Tab/ErrorPageTests.swift:334 - XCTAssertEqual failed: ("Optional("test.com")") is not equal to ("Optional("test page")")

Check failure on line 1 in DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Integration Tests.build/Objects-normal/arm64/ErrorPageTests.d

See this annotation in the file changed.

@github-actions github-actions / Test Report: Non-Sandbox

ErrorPageTests.testWhenGoingBackToFailingPage_reloadIsTriggered 

/Users/runner/work/macos-browser/macos-browser/IntegrationTests/Tab/ErrorPageTests.swift:336 - XCTAssertEqual failed: ("Optional("test.com")") is not equal to ("Optional("test page")")

Check failure on line 1 in DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Integration Tests.build/Objects-normal/arm64/ErrorPageTests.d

See this annotation in the file changed.

@github-actions github-actions / Test Report: Non-Sandbox

ErrorPageTests.testWhenPageLoadedAndFailsOnRefreshAndSucceedsOnConsequentRefresh_forwardHistoryIsPreserved 

/Users/runner/work/macos-browser/macos-browser/IntegrationTests/Tab/ErrorPageTests.swift:545 - XCTAssertEqual failed: ("Optional("alternative.com")") is not equal to ("Optional("alternative page")")
View more details on GitHub Actions