Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix safari file not found error handling #2242

Merged
merged 2 commits into from
Feb 26, 2024
Merged

fix safari file not found error handling #2242

merged 2 commits into from
Feb 26, 2024

Conversation

mallexxx
Copy link
Collaborator

@mallexxx mallexxx commented Feb 22, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/1177771139624306/1206650450402962/f

Description:

  • Fix Safari bookmarks file not found error message (show "we could not found any bookmarks" instead of an error)

Steps to test this PR:

  1. Create new user
  2. Run data import from Safari, validate "We could not found any bookmarks" error is displayed; Validate when bookmarks are added to Safari import works
  3. Validate on Sandboxed build
Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@mallexxx mallexxx requested a review from ayoy February 22, 2024 13:29
ayoy
ayoy approved these changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @mallexxx! Allow me to merge it so that it's included in today's release.

@ayoy ayoy merged commit 335e033 into main Feb 26, 2024
16 of 17 checks passed
@ayoy ayoy deleted the alex/fix-safari-no-bookmarks-error branch February 26, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayoy ayoy ayoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mallexxx @ayoy