Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBP API changes for WebUI - Release #2233

Merged
merged 21 commits into from
Feb 21, 2024
Merged

DBP API changes for WebUI - Release #2233

merged 21 commits into from
Feb 21, 2024

Conversation

Bunn
Copy link
Collaborator

@Bunn Bunn commented Feb 21, 2024 •
edited
Loading

Cherry picked from #2146
Task/Issue URL: https://app.asana.com/0/1204167627774280/1206480273655878/f

Description:
Add url property to data broker model, and changes result for WebUI call to support new UI designs

Steps to test this PR:
The most important thing to test is the database migration.

  1. Open the app with the main branch, create a profile and do the scans
  2. Open this PR and check if your information is still there and that all brokers have an url and name property
  3. You might want to return nil here to force the JSON updates
  4. Test the new web UI https://use-devtesting9.duckduckgo.com/dbp

Bunn added 18 commits February 21, 2024 12:41
@Bunn
WIP: databroker API
40213b3 
https://app.asana.com/0/1204167627774280/1206451739604149/f
@Bunn
Add mock URL
92c3322
@Bunn
Remove duped from getDataBroker
4db9381
@Bunn
WIP: Update the schedule API
d7226a2 
https://app.asana.com/0/1204167627774280/1206451739604152/f
@Bunn
Remove dupes
93668c5
@Bunn
completed opt-out changes
932c75c 
https://app.asana.com/0/0/1206451739604162/f
@Bunn
Fix DB browser cell height
e9be615
@Bunn
Add url property and migrations
cc0468d
@Bunn
Fix migration
49b78af
@Bunn
Fix test model
7bbb316 
# Conflicts:
#	LocalPackages/DataBrokerProtection/Tests/DataBrokerProtectionTests/DataBrokerProtectionUpdaterTests.swift
@Bunn
Fix tests
4a9994b
@Bunn
Update JSON
40d4883
@Bunn
Fix typo
18df9bf
@Bunn
Remove unnecessary do/catch
17356d5
@Bunn
Improve getBrokers readability
9a52148
@Bunn
Add tests
eab70a8
@Bunn
Add mirror sites
9bba302
@Bunn
Bump version number
1be1a4d 
# Conflicts:
#	LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/UI/DBPUICommunicationLayer.swift
@Bunn Bunn requested a review from jotaemepereira February 21, 2024 12:57
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 21, 2024 •
edited
Loading

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against b111542

jotaemepereira
jotaemepereira approved these changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@jotaemepereira jotaemepereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and it looks good to me 👍🏼

@Bunn Bunn merged commit 5e2a8c0 into release/1.76.0 Feb 21, 2024
21 checks passed
@Bunn Bunn deleted the bunn/dbp/release-ui-changes branch February 21, 2024 18:39
@Bunn Bunn mentioned this pull request Feb 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jotaemepereira jotaemepereira jotaemepereira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bunn @jotaemepereira