DBP API changes for WebUI #2146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bot: not in app board
github-actions
bot
removed
the
bot: not in app board
Bunn
commented
Feb 5, 2024
...ataBrokerProtection/Sources/DataBrokerProtection/DebugUI/DataBrokerDatabaseBrowserView.swift
Outdated
Show resolved
Hide resolved
jotaemepereira
requested changes
Feb 5, 2024
LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Model/DataBroker.swift
Show resolved
Hide resolved
...BrokerProtection/Sources/DataBrokerProtection/Database/DataBrokerProtectionDataManager.swift
Show resolved
Hide resolved
...kages/DataBrokerProtection/Sources/DataBrokerProtection/Operations/DataBrokerOperation.swift
Outdated
Show resolved
Hide resolved
LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Services/EmailService.swift
Outdated
Show resolved
Hide resolved
...erProtection/Sources/DataBrokerProtection/Storage/DataBrokerProtectionDatabaseProvider.swift
Outdated
Show resolved
Hide resolved
| do { | ||
| if try database.tableExists(BrokerDB.databaseTableName) { | ||
| try database.alter(table: BrokerDB.databaseTableName) { | ||
| $0.add(column: BrokerDB.Columns.url.name, .text) |
There was a problem hiding this comment.
$0.add(column: BrokerDB.Columns.url.name, .text).unique()
I have another question: should we remove the uniqueness from the name column? Is it possible for two brokers to have the same name but different URLs?
There was a problem hiding this comment.
Not an easy way to do this without some bigger changes. It's probably possible to create a tmp table, move things there, drop the current one and re-create with the unique property but I don't think it's worth the effort now.
https://www.sqlite.org/lang_altertable.html
The column may not have a PRIMARY KEY or UNIQUE constraint.
jotaemepereira
approved these changes
Feb 5, 2024
# Conflicts: # LocalPackages/DataBrokerProtection/Tests/DataBrokerProtectionTests/DataBrokerProtectionUpdaterTests.swift
Bunn
added a commit
that referenced
this pull request
Feb 21, 2024
Cherry picked from #2146 Task/Issue URL: https://app.asana.com/0/1204167627774280/1206480273655878/f **Description**: Add url property to data broker model, and changes result for WebUI call to support new UI designs
|
Closed in favor of #2233 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1204167627774280/1206480273655878/f
Description:
Add url property to data broker model, and changes result for WebUI call to support new UI designs
Steps to test this PR:
The most important thing to test is the database migration.