Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump BrowserServicesKit Version #2063

Merged
merged 10 commits into from
Jan 17, 2024
Merged

Conversation

brianhall
Copy link
Collaborator

@brianhall brianhall commented Jan 15, 2024

Task/Issue URL: https://app.asana.com/0/0/1206352789801869/f
Tech Design URL:
CC:

Description:
This is a minor fix to C-S-S that only affects Personal Information Removal. Also includes the new JSON files originally created in #2060.

Steps to test this PR:
1.


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@brianhall brianhall marked this pull request as ready for review January 16, 2024 15:52
@brianhall brianhall requested a review from afterxleep January 16, 2024 15:58
@brianhall brianhall force-pushed the bhall/check-browser-services-kit branch from f0d81d7 to 22cacee Compare January 17, 2024 15:01
Copy link
Contributor

github-actions bot commented Jan 17, 2024

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against 32d61d2

Copy link
Collaborator

@Bunn Bunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All brokers were correctly parsed (I can see them correctly displayed in the DB). It's worth noting that some of those brokers are blocking my IP, so I did not conduct an extensive test to determine whether the steps themselves are working, only that the macOS is correctly handling the new JSON.

LGTM

@brianhall brianhall merged commit b0bc72b into main Jan 17, 2024
14 checks passed
@brianhall brianhall deleted the bhall/check-browser-services-kit branch January 17, 2024 20:52
samsymons added a commit that referenced this pull request Jan 18, 2024
* main:
  Bump BrowserServicesKit Version (#2063)
  Bump autoconsent to 9.1.0 (#2067)
  Fix casing in some copy items in Preferences and Main Menu (#2070)
  Fix vertical alignment of privacy feed shield icon (#2069)
  Fix giving focus to webView when it's loaded in BrowserTabViewController (#2073)
  Increase polling interval for captcha solver (#2071)
  Add a link to help page in location permission popup (#2017)
  Add bookmark popover in SwiftUI (#2036)
  Better detection of AMP pages (#2001)
  UI adjustments for improved VPN user control (#2043)
  Don't override drop operation if source view is webView (#2058)
  Bump version to 1.71.0 (104)
  Set marketing version to 1.71.0
  Update embedded files
samsymons added a commit that referenced this pull request Jan 19, 2024
* main:
  Fix Gatekeeper dialog for binaries downloaded by the browser (#2068)
  Display "Copy Email Address" context menu action for email links (#2076)
  add pixels for sync flows (#2056)
  Sign up with Apple bug fix (#2083)
  Improve DBP onboarding experience for FE devs (#2082)
  Prompt for Primary Password for FF Key3.db logins (#2066)
  Throw error on import database mapping error (#2065)
  Bump BrowserServicesKit Version (#2063)
  Bump autoconsent to 9.1.0 (#2067)
  Fix casing in some copy items in Preferences and Main Menu (#2070)
  Fix vertical alignment of privacy feed shield icon (#2069)
  Fix giving focus to webView when it's loaded in BrowserTabViewController (#2073)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants