Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional Broker JSON files #2060

Closed
wants to merge 2 commits into from
Closed

Conversation

brianhall
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/0/1206341248007575/f
Tech Design URL:
CC:

Description:
Adds the following brokers:

  • Verecor child sites:
    • backgroundcheck.run
    • clubset.com
    • councilon.com
    • curadvisor.com
    • kwold.com
    • people-background-check.com
    • newenglandfacts.com
    • publicreports.com
    • virtory.com
    • wellnut.com
  • PeopleFinders child sites:
    • searchpeoplefree.com
    • truepeoplesearch.com

Steps to test this PR:

  1. Do a scan in PIR
  2. You should see results coming from these brokers, and no broker errors in the database.

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Contributor

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against 8efa4a4

@brianhall
Copy link
Collaborator Author

Marking as DO NOT MERGE for now until I can coordinate a C-S-S release that should go alongside this.

@brianhall
Copy link
Collaborator Author

Closing as these changes have been merged into #2063 so that we do the version bump at the same time.

@brianhall brianhall closed this Jan 17, 2024
@brianhall brianhall deleted the bhall/update-broker-json branch January 17, 2024 15:26
brianhall added a commit that referenced this pull request Jan 17, 2024
Task/Issue URL: https://app.asana.com/0/0/1206352789801869/f
Tech Design URL:
CC:

**Description**:
This is a minor fix to C-S-S that only affects Personal Information
Removal. Also includes the new JSON files originally created in #2060.

**Steps to test this PR**:
1.

<!--
Tagging instructions
If this PR isn't ready to be merged for whatever reason it should be
marked with the `DO NOT MERGE` label (particularly if it's a draft)
If it's pending Product Review/PFR, please add the `Pending Product
Review` label.

If at any point it isn't actively being worked on/ready for
review/otherwise moving forward (besides the above PR/PFR exception)
strongly consider closing it (or not opening it in the first place). If
you decide not to close it, make sure it's labelled to make it clear the
PRs state and comment with more information.
-->

---
###### Internal references:
[Pull Request Review
Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f)
[Software Engineering
Expectations](https://app.asana.com/0/59792373528535/199064865822552)
[Technical Design
Template](https://app.asana.com/0/59792373528535/184709971311943)
[Pull Request
Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)

---------

Co-authored-by: Fernando Bunn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant