Remove the reconnect/disconnect logic from the connection tester #1970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 14, 2023
Merged
diegoreymendez
changed the title
diegoreymendez
commented
Dec 14, 2023
| @@ -87,7 +87,7 @@ final class NetworkProtectionNavBarButtonModel: NSObject, ObservableObject { | |||
| statusObserver: ipcClient.connectionStatusObserver, | |||
| serverInfoObserver: ipcClient.serverInfoObserver, | |||
| connectionErrorObserver: ipcClient.connectionErrorObserver, | |||
| connectivityIssuesObserver: ConnectivityIssueObserverThroughDistributedNotifications(), | |||
| connectivityIssuesObserver: DisabledConnectivityIssueObserver(), | |||
There was a problem hiding this comment.
This was removed due to this comment.
|
The behaviour was as described 👍 |
quanganhdo
approved these changes
Dec 14, 2023
diegoreymendez
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Dec 15, 2023
Task/Issue URL: https://app.asana.com/0/0/1206173513538620/f iOS PR: duckduckgo/iOS#2272 macOS PR: duckduckgo/macos-browser#1970 What kind of version bump will this require?: Patch ## Description Removes the logic that would reconnect / disconnect NetP in case of trouble.
diegoreymendez
added a commit
to duckduckgo/iOS
that referenced
this pull request
Dec 15, 2023
Task/Issue URL: https://app.asana.com/0/0/1206173513538619/f macOS PR: duckduckgo/macos-browser#1970 BSK PR: duckduckgo/BrowserServicesKit#601 ## Description Removes the logic that would reconnect / disconnect NetP in case of trouble.
samsymons
added a commit
that referenced
this pull request
Dec 15, 2023
* main: Updates to Autofill Logins copy (#1924) Bump version to 1.69.0 (95) Remove the reconnect/disconnect logic from the connection tester (#1970) Set marketing version to 1.69.0 Update embedded files DBP: Send internal user param for dbp waitlist pixels (#1972) Move release task to proper section in Code Freeze workflow (#1977) drop Main.storyboard (#1944) Add GHA workflow to cut release branch (#1976) Move DBP tests into main target (#1974) Use static date for PixelKit tests (#1973)
samsymons
added a commit
that referenced
this pull request
Dec 15, 2023
* main: (48 commits) Add additional VPN startup pixels (#1975) Updates to Autofill Logins copy (#1924) Bump version to 1.69.0 (95) Remove the reconnect/disconnect logic from the connection tester (#1970) Set marketing version to 1.69.0 Update embedded files DBP: Send internal user param for dbp waitlist pixels (#1972) Move release task to proper section in Code Freeze workflow (#1977) drop Main.storyboard (#1944) Add GHA workflow to cut release branch (#1976) Move DBP tests into main target (#1974) Use static date for PixelKit tests (#1973) Remove DBP test target (#1961) Fix date generator for time machine (#1969) Improve sync set up error handling (#1966) remove QR code from save recovery PDF view (#1968) change order of items in autofill add new item (#1967) Fix PR Checks workflow (#1962) Bump version to 1.68.0 (93) Update embedded files ...
samsymons
added a commit
that referenced
this pull request
Dec 19, 2023
* main: DBP: Fix unreliable date tests (#1981) Add search retention pixel for NetP (#1964) Sabrina/sync e2e tests (#1959) swiftlint build plugin (#1318) VPN Geoswitching - initial draft (#1978) Add additional VPN startup pixels (#1975) Updates to Autofill Logins copy (#1924) Bump version to 1.69.0 (95) Remove the reconnect/disconnect logic from the connection tester (#1970) Set marketing version to 1.69.0 Update embedded files DBP: Send internal user param for dbp waitlist pixels (#1972) Move release task to proper section in Code Freeze workflow (#1977) drop Main.storyboard (#1944) Add GHA workflow to cut release branch (#1976) Move DBP tests into main target (#1974) Use static date for PixelKit tests (#1973)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1206173513538618/f
iOS PR: duckduckgo/iOS#2272
BSK PR: duckduckgo/BrowserServicesKit#601
Description
Removes the disconnect / reconnect logic from the connection tester.
Testing
2.Launch the app, and connect NetP, make sure the connection works.
sudo pfctl -ef ~/Desktop/ruleset.txtInternal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation