Remove the reconnect/disconnect logic from the connection tester #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 14, 2023
Merged
diegoreymendez
changed the title
quanganhdo
approved these changes
Dec 14, 2023
diegoreymendez
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Dec 15, 2023
Task/Issue URL: https://app.asana.com/0/0/1206173513538618/f iOS PR: duckduckgo/iOS#2272 BSK PR: duckduckgo/BrowserServicesKit#601 ## Description Removes the disconnect / reconnect logic from the connection tester.
diegoreymendez
added a commit
to duckduckgo/iOS
that referenced
this pull request
Dec 15, 2023
Task/Issue URL: https://app.asana.com/0/0/1206173513538619/f macOS PR: duckduckgo/macos-browser#1970 BSK PR: duckduckgo/BrowserServicesKit#601 ## Description Removes the logic that would reconnect / disconnect NetP in case of trouble.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1206173513538620/f
iOS PR: duckduckgo/iOS#2272
macOS PR: duckduckgo/macos-browser#1970
What kind of version bump will this require?: Patch
Description
Removes the logic that would reconnect / disconnect NetP in case of trouble.
Testing
See platform-specific PRs for testing instructions.
Internal references:
Software Engineering Expectations
Technical Design Template