Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Environment setting to the Debug menu #1788

Merged
merged 10 commits into from
Nov 9, 2023
Merged

Conversation

quanganhdo
Copy link
Member

@quanganhdo quanganhdo commented Oct 31, 2023

Task/Issue URL: https://app.asana.com/0/1199230911884351/1204544375475063/f

Description:

Steps to test this PR:

  1. Go to Debug > Network Protection > Environment
  2. Choose either Production or Staging
  3. Go to Debug > Network Protection > Preferred Server. The server list should update accordingly
  4. Pick any server. You should connect to that particular server under the selected environment

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Contributor

@diegoreymendez diegoreymendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, nice work!

@quanganhdo quanganhdo force-pushed the anh/select-environment branch from e1d56d5 to a7d5617 Compare November 9, 2023 17:53
@quanganhdo quanganhdo force-pushed the anh/select-environment branch from 86e4c40 to 9020219 Compare November 9, 2023 19:07
@quanganhdo quanganhdo force-pushed the anh/select-environment branch from 9020219 to 1835073 Compare November 9, 2023 19:09
@quanganhdo quanganhdo merged commit 8deabfa into develop Nov 9, 2023
16 checks passed
@quanganhdo quanganhdo deleted the anh/select-environment branch November 9, 2023 20:11
samsymons added a commit that referenced this pull request Nov 12, 2023
* develop:
  Restart agent when app is launched (#1835)
  Update waitlist brokers number from 75+ to 17+ (#1837)
  Sync form factor specific favorites (#1656)
  Skip Make Release Build in PR Checks on Dependabot pull requests (#1831)
  switch to true|false for protectionsState param (#1825)
  Set origin policy for CCF (#1804)
  Add Environment setting to the Debug menu (#1788)
  Bump Submodules/privacy-reference-tests from `0d23f76` to `7519c3d` (#1821)
  Refactor DBP invite code storage to use the keychain (#1818)
  Add test:1 to website breakage tests in case we might fire an actual request (eventually) (#1823)
  Update BSK to 82.2.3 (#1824)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants