Add selected environment preference #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quanganhdo
changed the title
quanganhdo
force-pushed
the
anh/select-environment
branch
from
7d7f125 to
cf11292
Compare
diegoreymendez
approved these changes
Nov 9, 2023
Sources/NetworkProtection/Networking/NetworkProtectionClient.swift
Outdated
Show resolved
Hide resolved
quanganhdo
force-pushed
the
anh/select-environment
branch
from
ef45537 to
ad26ace
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199230911884351/1204544375475063/f
iOS PR: duckduckgo/iOS#2140
macOS PR: duckduckgo/macos-browser#1788
What kind of version bump will this require?: Minor
Description:
Adds the ability to specify the environment endpoint (either
productionorstaging). Also merges the changes from #552.Steps to test this PR:
See the macOS PR.
Internal references:
Software Engineering Expectations
Technical Design Template