Data Import ux redo

Configuration/Global.xcconfig

@@ -101,3 +101,10 @@ DDG_SLOW_COMPILE_CHECK_THRESHOLD[config=CI] = 250
 DDG_SLOW_COMPILE_CHECK = -Xfrontend -warn-long-expression-type-checking=$(DDG_SLOW_COMPILE_CHECK_THRESHOLD) -Xfrontend -warn-long-function-bodies=$(DDG_SLOW_COMPILE_CHECK_THRESHOLD)
 OTHER_SWIFT_FLAGS[config=Debug][arch=*][sdk=*] = $(inherited) $(DDG_SLOW_COMPILE_CHECK)
 OTHER_SWIFT_FLAGS[config=CI][arch=*][sdk=*] = $(inherited) $(DDG_SLOW_COMPILE_CHECK)
+
+// Automatically generate Color and Image asset accessor extensions
+ASSETCATALOG_COMPILER_GENERATE_SWIFT_ASSET_SYMBOL_EXTENSIONS = YES
+
+// Automatically generate localization string catalogs
+LOCALIZATION_PREFERS_STRING_CATALOGS = YES
+SWIFT_EMIT_LOC_STRINGS = YES

DuckDuckGo.xcodeproj/xcshareddata/xcschemes/DuckDuckGo Privacy Browser App Store.xcscheme

@@ -54,7 +54,8 @@
       buildConfiguration = "Debug"
       selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
       selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
-      shouldUseLaunchSchemeArgsEnv = "YES">
+      shouldUseLaunchSchemeArgsEnv = "YES"
+      codeCoverageEnabled = "YES">
       <PreActions>
          <ExecutionAction
             ActionType = "Xcode.IDEStandardExecutionActionsCore.ExecutionActionType.ShellScriptAction">

DuckDuckGo/Assets.xcassets/Images/Import-Export-16.imageset/Contents.json

@@ -0,0 +1,15 @@
+{
+  "images" : [
+    {
+      "filename" : "Import-Export-16D.pdf",
+      "idiom" : "universal"
+    }
+  ],
+  "info" : {
+    "author" : "xcode",
+    "version" : 1
+  },
+  "properties" : {
+    "template-rendering-intent" : "template"
+  }
+}

DuckDuckGo/Assets.xcassets/Images/Menu-Hamburger-16.imageset/Contents.json

@@ -0,0 +1,15 @@
+{
+  "images" : [
+    {
+      "filename" : "Menu-Hamburger-16.pdf",
+      "idiom" : "universal"
+    }
+  ],
+  "info" : {
+    "author" : "xcode",
+    "version" : 1
+  },
+  "properties" : {
+    "template-rendering-intent" : "template"
+  }
+}

DuckDuckGo/Assets.xcassets/Images/Menu-Horizontal-16.imageset/Contents.json

@@ -0,0 +1,15 @@
+{
+  "images" : [
+    {
+      "filename" : "Menu-16.pdf",
+      "idiom" : "universal"
+    }
+  ],
+  "info" : {
+    "author" : "xcode",
+    "version" : 1
+  },
+  "properties" : {
+    "template-rendering-intent" : "template"
+  }
+}

DuckDuckGo/Assets.xcassets/Images/Menu-Vertical-16.imageset/Contents.json

@@ -0,0 +1,15 @@
+{
+  "images" : [
+    {
+      "filename" : "Menu-Vertical-16.pdf",
+      "idiom" : "universal"
+    }
+  ],
+  "info" : {
+    "author" : "xcode",
+    "version" : 1
+  },
+  "properties" : {
+    "template-rendering-intent" : "template"
+  }
+}

DuckDuckGo/Bookmarks/Model/BookmarkManager.swift

@@ -43,7 +43,7 @@ protocol BookmarkManager: AnyObject {
     func canMoveObjectWithUUID(objectUUID uuid: String, to parent: BookmarkFolder) -> Bool
     func move(objectUUIDs: [String], toIndex: Int?, withinParentFolder: ParentFolderType, completion: @escaping (Error?) -> Void)
     func moveFavorites(with objectUUIDs: [String], toIndex: Int?, completion: @escaping (Error?) -> Void)
-    func importBookmarks(_ bookmarks: ImportedBookmarks, source: BookmarkImportSource) -> BookmarkImportResult
+    func importBookmarks(_ bookmarks: ImportedBookmarks, source: BookmarkImportSource) -> BookmarksImportSummary
 
     func handleFavoritesAfterDisablingSync()
 
@@ -313,7 +313,7 @@ final class LocalBookmarkManager: BookmarkManager {
 
     // MARK: - Import
 
-    func importBookmarks(_ bookmarks: ImportedBookmarks, source: BookmarkImportSource) -> BookmarkImportResult {
+    func importBookmarks(_ bookmarks: ImportedBookmarks, source: BookmarkImportSource) -> BookmarksImportSummary {
         let results = bookmarkStore.importBookmarks(bookmarks, source: source)
         loadBookmarks()
         requestSync()

DuckDuckGo/Bookmarks/Services/BookmarkStore.swift

@@ -30,12 +30,12 @@ enum ParentFolderType {
     case parent(uuid: String)
 }
 
-struct BookmarkImportResult: Equatable {
+struct BookmarksImportSummary: Equatable {
     var successful: Int
     var duplicates: Int
     var failed: Int
 
-    static func += (left: inout BookmarkImportResult, right: BookmarkImportResult) {
+    static func += (left: inout BookmarksImportSummary, right: BookmarksImportSummary) {
         left.successful += right.successful
         left.duplicates += right.duplicates
         left.failed += right.failed
@@ -57,7 +57,7 @@ protocol BookmarkStore {
     func canMoveObjectWithUUID(objectUUID uuid: String, to parent: BookmarkFolder) -> Bool
     func move(objectUUIDs: [String], toIndex: Int?, withinParentFolder: ParentFolderType, completion: @escaping (Error?) -> Void)
     func moveFavorites(with objectUUIDs: [String], toIndex: Int?, completion: @escaping (Error?) -> Void)
-    func importBookmarks(_ bookmarks: ImportedBookmarks, source: BookmarkImportSource) -> BookmarkImportResult
+    func importBookmarks(_ bookmarks: ImportedBookmarks, source: BookmarkImportSource) -> BookmarksImportSummary
 
     func handleFavoritesAfterDisablingSync()
 }

DuckDuckGo/Bookmarks/Services/BookmarkStoreMock.swift

@@ -110,9 +110,9 @@ public final class BookmarkStoreMock: BookmarkStore {
     }
 
     var importBookmarksCalled = false
-    func importBookmarks(_ bookmarks: ImportedBookmarks, source: BookmarkImportSource) -> BookmarkImportResult {
+    func importBookmarks(_ bookmarks: ImportedBookmarks, source: BookmarkImportSource) -> BookmarksImportSummary {
         importBookmarksCalled = true
-        return BookmarkImportResult(successful: 0, duplicates: 0, failed: 0)
+        return BookmarksImportSummary(successful: 0, duplicates: 0, failed: 0)
     }
 
     var canMoveObjectWithUUIDCalled = false

DuckDuckGo/Bookmarks/Services/LocalBookmarkStore.swift

@@ -705,8 +705,8 @@ final class LocalBookmarkStore: BookmarkStore {
     /// 2. **Safari:** Create a root level "Imported Favorites" folder to store bookmarks from the bookmarks bar, and all other bookmarks go at the root level.
     /// 3. **Chrome:** Put all bookmarks at the root level, except for Other Bookmarks which go in a root level "Other Bookmarks" folder.
     /// 4. **Firefox:** Put all bookmarks at the root level, except for Other Bookmarks which go in a root level "Other Bookmarks" folder.
-    func importBookmarks(_ bookmarks: ImportedBookmarks, source: BookmarkImportSource) -> BookmarkImportResult {
-        var total = BookmarkImportResult(successful: 0, duplicates: 0, failed: 0)
+    func importBookmarks(_ bookmarks: ImportedBookmarks, source: BookmarkImportSource) -> BookmarksImportSummary {
+        var total = BookmarksImportSummary(successful: 0, duplicates: 0, failed: 0)
 
         do {
             let context = makeContext()
@@ -747,15 +747,15 @@ final class LocalBookmarkStore: BookmarkStore {
     private func createEntitiesFromBookmarks(allFolders: [BookmarkEntity],
                                              bookmarks: ImportedBookmarks,
                                              importSourceName: String,
-                                             in context: NSManagedObjectContext) -> BookmarkImportResult {
+                                             in context: NSManagedObjectContext) -> BookmarksImportSummary {
 
         guard let root = bookmarksRoot(in: context) else {
             return .init(successful: 0,
                          duplicates: 0,
                          failed: bookmarks.numberOfBookmarks)
         }
 
-        var total = BookmarkImportResult(successful: 0, duplicates: 0, failed: 0)
+        var total = BookmarksImportSummary(successful: 0, duplicates: 0, failed: 0)
 
         var parent = root
         var makeFavorties = true
@@ -791,8 +791,8 @@ final class LocalBookmarkStore: BookmarkStore {
     private func recursivelyCreateEntities(from bookmarks: [ImportedBookmarks.BookmarkOrFolder],
                                            parent: BookmarkEntity,
                                            markBookmarksAsFavorite: Bool? = false,
-                                           in context: NSManagedObjectContext) -> BookmarkImportResult {
-        var total = BookmarkImportResult(successful: 0, duplicates: 0, failed: 0)
+                                           in context: NSManagedObjectContext) -> BookmarksImportSummary {
+        var total = BookmarksImportSummary(successful: 0, duplicates: 0, failed: 0)
 
         let favoritesFolders = BookmarkUtils.fetchFavoritesFolders(for: favoritesDisplayMode, in: context)
 

DuckDuckGo/Bookmarks/View/BookmarkListViewController.swift

@@ -173,7 +173,7 @@ final class BookmarkListViewController: NSViewController {
     }
 
     @IBAction func onImportClicked(_ sender: NSButton) {
-        DataImportViewController.show()
+        DataImportView.show()
     }
 
     // MARK: NSOutlineView Configuration

DuckDuckGo/Bookmarks/View/BookmarkManagementDetailViewController.swift

@@ -125,7 +125,7 @@ final class BookmarkManagementDetailViewController: NSViewController, NSMenuItem
     }
 
     @IBAction func onImportClicked(_ sender: NSButton) {
-        DataImportViewController.show()
+        DataImportView.show()
     }
 
     @IBAction func handleDoubleClick(_ sender: NSTableView) {

DuckDuckGo/Common/Extensions/NSColorExtension.swift

@@ -74,10 +74,6 @@ extension NSColor {
         NSColor(named: "FindInPageFocusedBackgroundColor")!
     }
 
-    static var inactiveSearchBarBackground: NSColor {
-        NSColor(named: "InactiveSearchBarBackground")!
-    }
-
     static var suggestionTextColor: NSColor {
         NSColor(named: "SuggestionTextColor")!
     }
@@ -138,14 +134,6 @@ extension NSColor {
         NSColor(named: "DialogPanelBackground")!
     }
 
-    static let bookmarkFilledTint = NSColor(named: "BookmarkFilledTint")!
-
-    static let bookmarkRepresentingColor1 = NSColor(named: "BookmarkRepresentingColor1")!
-    static let bookmarkRepresentingColor2 = NSColor(named: "BookmarkRepresentingColor2")!
-    static let bookmarkRepresentingColor3 = NSColor(named: "BookmarkRepresentingColor3")!
-    static let bookmarkRepresentingColor4 = NSColor(named: "BookmarkRepresentingColor4")!
-    static let bookmarkRepresentingColor5 = NSColor(named: "BookmarkRepresentingColor5")!
-
     static var buttonMouseDownColor: NSColor {
         NSColor(named: "ButtonMouseDownColor")!
     }

DuckDuckGo/Common/Extensions/NSOpenPanelExtensions.swift

@@ -33,14 +33,13 @@ extension NSOpenPanel {
         return panel
     }
 
-    static func filePanel(allowedExtension: String) -> NSOpenPanel {
-        let panel = NSOpenPanel()
-
-        panel.directoryURL = FileManager.default.homeDirectoryForCurrentUser.appendingPathComponent("Desktop")
-        panel.canChooseFiles = true
-        panel.allowedContentTypes = UTType(filenameExtension: allowedExtension).map { [$0] } ?? []
-        panel.canChooseDirectories = false
+    convenience init(allowedFileTypes: [UTType], directoryURL: URL? = nil) {
+        self.init()
 
-        return panel
+        self.directoryURL = directoryURL
+        canChooseFiles = true
+        allowedContentTypes = allowedFileTypes
+        canChooseDirectories = false
     }
+
 }

DuckDuckGo/Common/Extensions/NSWorkspaceExtension.swift

@@ -58,4 +58,12 @@ extension NSWorkspace {
         return missionControlWindows.count > allScreenSizes.count
     }
 
+    @available(macOS, obsoleted: 14.0, message: "This needs to be removed as it‘s no longer necessary.")
+    @nonobjc func urls(forApplicationsWithBundleId bundleId: String) -> [URL] {
+        if #available(macOS 12.0, *) {
+            return self.urlsForApplications(withBundleIdentifier: bundleId)
+        }
+        return LSCopyApplicationURLsForBundleIdentifier(bundleId as CFString, nil)?.takeRetainedValue() as? [URL] ?? []
+    }
+
 }

DuckDuckGo/Common/Extensions/SetExtension.swift

@@ -32,3 +32,11 @@ extension Set where Element == String {
     }
 
 }
+
+extension Set {
+
+    @inlinable func intersects<S: Sequence>(_ other: S) -> Bool where Element == S.Element {
+        !isDisjoint(with: other)
+    }
+
+}