Code

Data Import ux redo#1754

Code

Merged

mallexxx merged 96 commits intomainduckduckgo/macos-browser:mainfrom alex/improve-import-infoduckduckgo/macos-browser:alex/improve-import-infoCopy head branch name to clipboardDec 22, 2023

+17,277-4,895

Commits

Commits on Oct 9, 2023

• Add new browser import sources

  mallexxx

  committed
  988dbc8

• fix tests

  mallexxx

  committed
  5cdfa77

• Bitwarden source, Refactor CSV parser, improve column detection

  mallexxx

  committed
  b1ee94a

• minor cleanup

  mallexxx

  committed
  a64117c

• cleanup

  mallexxx

  committed
  8521ae3

Commits on Oct 10, 2023

• Add Passwords import as CSV step to Yandex

  mallexxx

  committed
  24a24ac

• rename ChromiumPreferences

  mallexxx

  committed
  4d21895

• handle ImportError separately in DataImportViewController

  mallexxx

  committed
  b60be62

• rename ChromiumPreferences in pbxproj

  mallexxx

  committed
  748c285

• fix browser isInstalled detection

  mallexxx

  committed
  e7a5566

• Fix a glitch on switching import button state when changing import sources; Update Firefox MoreInfo to include actual browser name

  mallexxx

  committed
  fc03dd1

• Merge remote-tracking branch 'origin/develop' into alex/new-import-browsers

  mallexxx

  committed
  bafd5e7

Commits on Oct 12, 2023

• Merge branch 'alex/new-import-browsers' into alex/improve-import-info

  mallexxx

  committed
  620a01e

• Merge branch 'alex/new-import-csv' into alex/improve-import-info

  mallexxx

  committed
  46de2a9

• Disable import passwords/bookmarks checkboxes if data file not found

  mallexxx

  committed
  491a801

• fix tests

  mallexxx

  committed
  fb55c63

Commits on Nov 6, 2023

• Merge remote-tracking branch 'origin/develop' into alex/improve-import-info

  mallexxx

  committed
  8f4531c

Commits on Nov 17, 2023

• Merge branch 'develop' into alex/new-import-browsers

  mallexxx

  committed
  c642307

• Bitwarden source, Refactor CSV parser, improve column detection (#1740)

  Show description for c50b7f0
  mallexxx

  authored
  c50b7f0

• Merge remote-tracking branch 'origin/develop' into alex/improve-import-info

  mallexxx

  committed
  1358f18

• Merge remote-tracking branch 'origin/alex/new-import-browsers' into alex/improve-import-info

  mallexxx

  committed
  74d8c5b

• New Data Import UX in SwiftUI

  mallexxx

  committed
  5348e1e

• show summary if all sources succeeded; disable Select file button when in progress

  mallexxx

  committed
  7a6cb40

• fix CSV, 1Password 8 selection in picker; Remove Skip button for file-import-only sources

  mallexxx

  committed
  ea33df9

• fix build

  mallexxx

  committed
  795c1dc

• cleanup

  mallexxx

  committed
  278820a

Commits on Nov 20, 2023

• refactor data import feedback

  mallexxx

  committed
  5b28b0e

• fix typo

  mallexxx

  committed
  0771496

• fix pbxproj

  mallexxx

  committed
  552d318

• fix typo

  mallexxx

  committed
  8848513

Commits on Nov 21, 2023

• remove source arg from Importers

  mallexxx

  committed
  76025c2

• fix tests

  mallexxx

  committed
  132f3fd

• fix linter issues

  mallexxx

  committed
  32d92f4

• update CSV import source name

  mallexxx

  committed
  e00d76b

• fix build

  mallexxx

  committed
  e64a46a

• fix invalid profile folders shown for tor/firefox

  mallexxx

  committed
  1ed18de

Commits on Nov 22, 2023

• allow file drop on file import button

  mallexxx

  committed
  76d28f0

Commits on Nov 23, 2023

• code adjustment; handle chromium userDeniedKeychainPrompt

  mallexxx

  committed
  3e78e35

• rollback unneded pbxproj changes

  mallexxx

  committed
  627e442

• rollback failing test

  mallexxx

  committed
  c726e5c

Commits on Nov 24, 2023

• Validate profiles data in profile picker

  mallexxx

  committed
  cf0b6fa

• adjust data import view after ship review

  mallexxx

  committed
  ff589e1

• Localizable xcstrings

  mallexxx

  committed
  be4cf26

Commits on Nov 27, 2023

• add comments, naming adjustment, add suppot for custom localized arguments positioning

  mallexxx

  committed
  15418c4

• add localization comments

  mallexxx

  committed
  b445919

Commits on Dec 4, 2023

• mostly there; tests in progress

  mallexxx

  committed
  245bbe6

• show back button on getReadPermission, noData screens

  mallexxx

  committed
  eb80e9a

• spaces

  mallexxx

  committed
  03e327f

Commits on Dec 7, 2023

• Merge branch 'main' into alex/improve-import-info

  mallexxx

  committed
  80c92f5

• exclude .noData screen

  mallexxx

  committed
  9cbca92

• drop .noData screen

  mallexxx

  committed
  33e0748

• show Skip for failed passwords if there were errors

  mallexxx

  committed
  684a986

• don‘t get stuck on the same error screen

  mallexxx

  committed
  90603f9

• fix build

  mallexxx

  committed
  944f0fd

• fix build

  mallexxx

  committed
  5cd617f

Commits on Dec 12, 2023

• fix typo

  mallexxx

  committed
  774f067

• fix fiferox profile primary password

  mallexxx

  committed
  15eeb6c

• fix ux flow on failure

  mallexxx

  committed
  4a6f627

• design adjustments and fixes

  mallexxx

  committed
  c1ddad4

• fix yandex csv import instructions

  mallexxx

  committed
  f752210

Commits on Dec 13, 2023

• FileImportView testability

  mallexxx

  committed
  17165e5

• FileImportView instructions localization tests

  mallexxx

  committed
  e005c99

• fix naming

  mallexxx

  committed
  2f9d5fa

• rm todo

  mallexxx

  committed
  1f0c01c

Commits on Dec 15, 2023

• Merge remote-tracking branch 'origin/main' into alex/improve-import-info

  mallexxx

  committed
  d6c05f0

• added Review/simulated successful zero import result

  mallexxx

  committed
  7310f71

• fix pbxproj

  mallexxx

  committed
  df8b63b

• add throttled cancellable progress tracking to data importers/data import view

  mallexxx

  committed
  fb474be

• fix doubling import when keychain password/primary password rejected

  mallexxx

  committed
  7742cd8

• tests

  mallexxx

  committed
  64ba065

• fix linter issues

  mallexxx

  committed
  bd08e8f

• fix FileImportViewLocalizationTests CI assertions

  mallexxx

  committed
  3ee7d70

• Merge remote-tracking branch 'origin/main' into alex/improve-import-info

  mallexxx

  committed
  377ffea

• fix failing test

  mallexxx

  committed
  73cd5a1

• Show generic summary header when there‘s a failure in summary results

  mallexxx

  committed
  e452806

• align file import instructions with numbers in circles by top

  mallexxx

  committed
  252ef22

• add localization comment

  mallexxx

  committed
  549b4d6

Commits on Dec 17, 2023

• fix SwiftUI crash on Big Sur

  mallexxx

  committed
  fb60932

• fix dialog dismiss on Big Sur

  mallexxx

  committed
  8064382

• Ship review styling and copy fixes

  mallexxx

  committed
  5d5451b

• minor fixes

  mallexxx

  committed
  4e7fb31

• Merge remote-tracking branch 'origin/main' into alex/improve-import-info

  mallexxx

  committed
  9a5a0b3

Commits on Dec 18, 2023

• fix sandboxed build

  mallexxx

  committed
  5d054ca

• Merge remote-tracking branch 'origin/main' into alex/improve-import-info

  mallexxx

  committed
  6538b13

• fix missing import sources

  mallexxx

  committed
  36b47df

Commits on Dec 20, 2023

• minor styling fix

  mallexxx

  committed
  22d6d62

• add missing import

  mallexxx

  committed
  d5125d1

• fix support of Chrome Dev/Beta/Canary builds

  mallexxx

  committed
  8b1a452

• fix safari get read permission assertion

  mallexxx

  committed
  f588e0f

Commits on Dec 21, 2023

• fix feedback view styling, add focus ring

  mallexxx

  committed
  26b0c25

• fix invalid default profile selection

  mallexxx

  committed
  3916ead

• Merge remote-tracking branch 'origin/main' into alex/improve-import-info

  mallexxx

  committed
  5f19488

• cleanup files committed by mistake

  mallexxx

  committed
  5199d15

Commits on Dec 22, 2023

• last touches

  mallexxx

  committed
  761a444

• Report browser version in Pixel on data import failure (#1873)

  Show description for 04e69eb
  mallexxx

  authored
  04e69eb

• rm todo

  mallexxx

  committed
  ec97729