Skip to content
Danger JS

implement default zoom per site #9170

Sign in to view logs

implement default zoom per site

implement default zoom per site #9170

Triggered via pull request May 8, 2024 08:11
@SabrinaTardioSabrinaTardio
synchronize #2566
sabrina/improve-zoom-feature
Status Success
Total duration 2m 20s
Billable time 3m
Artifacts –

danger.yml

on: pull_request
Danger JS
2m 11s
Danger JS
Fit to window
Zoom out
Zoom in

Annotations

3 errors
AccessibilityPreferencesTests.test_whenBurningZoomLevels_thenOnlyFireproofSiteZoomLevelAreRetained: DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Unit Tests.build/Objects-normal/arm64/AccessibilityPreferencesTests.d#L1
/Users/runner/work/macos-browser/macos-browser/UnitTests/Preferences/AccessibilityPreferencesTests.swift:114 - XCTAssertEqual failed: ("nil") is not equal to ("Optional(DuckDuckGo_Privacy_Browser.DefaultZoomValue.percent100)")
AccessibilityPreferencesTests.test_whenBurningZoomLevels_thenOnlyFireproofSiteZoomLevelAreRetained: DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Unit Tests.build/Objects-normal/arm64/AccessibilityPreferencesTests.d#L1
/Users/runner/work/macos-browser/macos-browser/UnitTests/Preferences/AccessibilityPreferencesTests.swift:118 - XCTAssertEqual failed: ("nil") is not equal to ("Optional(1.0)")
TabViewModelTests.test_WhenZoomWasSetIsCalled_ThenAppearancePreferencesPerWebsiteZoomIsSet: DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Unit Tests.build/Objects-normal/arm64/TabViewModelTests.d#L1
/Users/runner/work/macos-browser/macos-browser/UnitTests/Tab/ViewModel/TabViewModelTests.swift:333 - XCTAssertEqual failed: ("nil") is not equal to ("Optional(DuckDuckGo_Privacy_Browser.DefaultZoomValue.percent50)")