Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement default zoom per site #2566

Merged
merged 28 commits into from
May 17, 2024
Merged

Conversation

SabrinaTardio
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/1177771139624306/1206933712061973/f

Description: Implements default Zoom per website

Steps to test this PR:

  1. Visit a website zoom in or out to a desired level
  2. Open a new tab visit the same website and check zoom level is retained (can also use the magnify lens in the address bar to check the current level)
  3. Open a different site and check the zoom level is the default one.
  4. Restart the app and check the zoom levels for each website are retained.
  5. check subdomain maintain the same zoom level.
  6. Test the zoom lens button on the address bar (zoom in till maximum value, till minimum, use reset) and check values are persisted.
  7. Check the lens is always visible when the zoom level of the page is not the default otherwise it should appear only when hovering on the bar.
  8. Check fire functionality removes saved zoom level

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Apr 8, 2024
Copy link
Contributor

github-actions bot commented Apr 8, 2024

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against a09f90e

@SabrinaTardio SabrinaTardio removed the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label May 7, 2024
@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label May 7, 2024
@SabrinaTardio SabrinaTardio removed the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label May 7, 2024
@SabrinaTardio SabrinaTardio marked this pull request as ready for review May 8, 2024 13:45
Copy link
Contributor

@tomasstrba tomasstrba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very handy feature 👏 It works well except one tiny issue. I have noticed "Change Default Page Zoom…" points to the wrong Settings page.

There are couple of code related comments below. In general, I think it would be beneficial to find delegate/observing patterns instead of notifications.

@SabrinaTardio SabrinaTardio requested a review from tomasstrba May 13, 2024 20:55
Copy link
Contributor

@tomasstrba tomasstrba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SabrinaTardio, I can't compile the latest version. Can you reproduce it?

Snímka obrazovky 2024-05-15 o 9 43 01 AM

private func subscribeToTabZoomLevel() {
accessibilityPreferencesCancellable = tabViewModel?.zoomLevelSubject
.sink { [weak self] _ in
self?.updateZoomButtonVisibility()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@tomasstrba tomasstrba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅ It works as expected! Good job 👏

@SabrinaTardio SabrinaTardio merged commit af516c7 into main May 17, 2024
19 checks passed
@SabrinaTardio SabrinaTardio deleted the sabrina/improve-zoom-feature branch May 17, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants