-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement default zoom per site #2566
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very handy feature 👏 It works well except one tiny issue. I have noticed "Change Default Page Zoom…" points to the wrong Settings page.
There are couple of code related comments below. In general, I think it would be beneficial to find delegate/observing patterns instead of notifications.
DuckDuckGo/NavigationBar/View/AddressBarButtonsViewController.swift
Outdated
Show resolved
Hide resolved
DuckDuckGo/NavigationBar/View/AddressBarButtonsViewController.swift
Outdated
Show resolved
Hide resolved
DuckDuckGo/NavigationBar/View/AddressBarButtonsViewController.swift
Outdated
Show resolved
Hide resolved
DuckDuckGo/NavigationBar/View/AddressBarButtonsViewController.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SabrinaTardio, I can't compile the latest version. Can you reproduce it?
private func subscribeToTabZoomLevel() { | ||
accessibilityPreferencesCancellable = tabViewModel?.zoomLevelSubject | ||
.sink { [weak self] _ in | ||
self?.updateZoomButtonVisibility() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✅ It works as expected! Good job 👏
Task/Issue URL: https://app.asana.com/0/1177771139624306/1206933712061973/f
Description: Implements default Zoom per website
Steps to test this PR:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation