Skip to content

implement default zoom per site #10198

implement default zoom per site

implement default zoom per site #10198

Triggered via pull request May 7, 2024 11:43
Status Failure
Total duration 5m 30s
Billable time 22m
Artifacts 2

pr.yml

on: pull_request
Matrix: Test
SwiftLint
1m 0s
SwiftLint
Test Shell Scripts
26s
Test Shell Scripts
Make Release Build
5m 7s
Make Release Build
Verify autoconsent bundle
11s
Verify autoconsent bundle
ShellCheck
6s
ShellCheck
Private API Report  /  Update PR comment
Private API Report / Update PR comment
Create Asana Task
0s
Create Asana Task
Close Asana Task
0s
Close Asana Task
Fit to window
Zoom out
Zoom in

Annotations

10 errors, 23 warnings, and 1 notice
Test (Non-Sandbox): UnitTests/Preferences/AccessibilityPreferencesTests.swift#L118
test_whenBurningZoomLevels_thenOnlyFireproofSiteZoomLevelAreRetained, XCTAssertEqual failed: ("nil") is not equal to ("Optional(DuckDuckGo_Privacy_Browser.DefaultZoomValue.percent100)")
Test (Non-Sandbox): UnitTests/Preferences/AccessibilityPreferencesTests.swift#L122
test_whenBurningZoomLevels_thenOnlyFireproofSiteZoomLevelAreRetained, XCTAssertEqual failed: ("nil") is not equal to ("Optional(1.0)")
Test (Non-Sandbox): UnitTests/Preferences/AccessibilityPreferencesTests.swift#L127
test_whenBurningZoomLevels_thenOnlyFireproofSiteZoomLevelAreRetained, XCTAssertEqual failed: ("nil") is not equal to ("Optional(1.0)")
Test (Non-Sandbox): UnitTests/Preferences/AccessibilityPreferencesTests.swift#L148
test_whenBurningZoomLevelsPerSites_thenZoomLevelOfTheSiteIsNotRetained, XCTAssertEqual failed: ("nil") is not equal to ("Optional(DuckDuckGo_Privacy_Browser.DefaultZoomValue.percent100)")
Test (Non-Sandbox): UnitTests/Preferences/AccessibilityPreferencesTests.swift#L152
test_whenBurningZoomLevelsPerSites_thenZoomLevelOfTheSiteIsNotRetained, XCTAssertEqual failed: ("nil") is not equal to ("Optional(1.0)")
Test (Non-Sandbox): UnitTests/Preferences/AccessibilityPreferencesTests.swift#L157
test_whenBurningZoomLevelsPerSites_thenZoomLevelOfTheSiteIsNotRetained, XCTAssertEqual failed: ("nil") is not equal to ("Optional(1.0)")
Test (Non-Sandbox): UnitTests/Tab/ViewModel/ZoomPopoverViewModelTests.swift#L80
test_WhenResetZoomFromPopover_ThenWebViewIsReset, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "Expect notification 'com.duckduckgo.app.ZoomPerWebsiteUpdated' from any object".
Test (Non-Sandbox)
Process completed with exit code 1.
Test (Sandbox)
The job was canceled because "Non-Sandbox" failed.
Test (Sandbox)
The operation was canceled.
Verify autoconsent bundle
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Test Shell Scripts
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mikepenz/action-junit-report@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Test (Non-Sandbox)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3, mikepenz/action-junit-report@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Test (Non-Sandbox): DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Test (Non-Sandbox): DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Test (Non-Sandbox)
not stripping binary because it is signed: /Users/runner/work/macos-browser/macos-browser/DerivedData/SourcePackages/artifacts/grdb.swift/GRDB/GRDB.xcframework/macos-arm64_x86_64/GRDB.framework/Versions/A/GRDB (in target 'DataBrokerProtectionTests' from project 'DataBrokerProtection')
Test (Non-Sandbox): UnitTests/Tab/ViewModel/TabViewModelTests.swift#L345
initialization of immutable value 'tabView' was never used; consider replacing with assignment to '_' or removing it
Test (Non-Sandbox): UnitTests/Tab/ViewModel/TabViewModelTests.swift#L370
initialization of immutable value 'tabView' was never used; consider replacing with assignment to '_' or removing it
Test (Non-Sandbox): UnitTests/Tab/ViewModel/TabViewModelTests.swift#L395
initialization of immutable value 'tabView' was never used; consider replacing with assignment to '_' or removing it
Test (Non-Sandbox): UnitTests/Tab/ViewModel/ZoomPopoverViewModelTests.swift#L73
initialization of immutable value 'expectation' was never used; consider replacing with assignment to '_' or removing it
Test (Non-Sandbox)
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
Test (Non-Sandbox)
DuckDuckGoDBPBackgroundAgent isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGoDBPBackgroundAgent' from project 'DuckDuckGo')
Test (Non-Sandbox)
DuckDuckGoVPN isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGoVPN' from project 'DuckDuckGo')
Test (Non-Sandbox)
No files were found with the provided path: Non-Sandbox-integrationtests-xcodebuild.log. No artifacts will be uploaded.
Test (Non-Sandbox)
No files were found with the provided path: Non-Sandbox-integrationtests.xcresult. No artifacts will be uploaded.
Make Release Build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Make Release Build: DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Make Release Build: DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Make Release Build: DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Make Release Build: DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Test (Sandbox): DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Test (Sandbox): DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Test (Sandbox): DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Test (Non-Sandbox)
Tests Passed: 0 failed, 0 skipped, 252 total (1.826 seconds)

Artifacts

Produced during runtime
Name Size
Non-Sandbox-unittests-xcodebuild.log Expired
720 KB
Non-Sandbox-unittests.xcresult Expired
77.2 MB