fix safari file not found error handling #7783
pr.yml
on: pull_request
Annotations
6 errors, 54 warnings, and 2 notices
Test (Non-Sandbox):
IntegrationTests/Tab/ErrorPageTests.swift#L334
testWhenGoingBackToFailingPage_reloadIsTriggered, XCTAssertEqual failed: ("Optional("test.com")") is not equal to ("Optional("test page")")
|
Test (Non-Sandbox):
IntegrationTests/Tab/ErrorPageTests.swift#L336
testWhenGoingBackToFailingPage_reloadIsTriggered, XCTAssertEqual failed: ("Optional("test.com")") is not equal to ("Optional("test page")")
|
Test (Non-Sandbox):
IntegrationTests/Tab/ErrorPageTests.swift#L545
testWhenPageLoadedAndFailsOnRefreshAndSucceedsOnConsequentRefresh_forwardHistoryIsPreserved, XCTAssertEqual failed: ("Optional("alternative.com")") is not equal to ("Optional("alternative page")")
|
Test (Sandbox):
CoreData#L1
(6922) I/O error for database at /var/folders/g9/4hls9p_s22bdrc8v5gzytvxc0000gn/T/com.duckduckgo.mobile.ios.Integration-Tests/Database.sqlite. SQLite error code:6922, 'disk I/O error'
|
Test (Sandbox):
CoreData#L1
SQLCore dispatchRequest: exception handling request: <NSSQLFetchRequestContext: 0x600001c4c000> , I/O error for database at /var/folders/g9/4hls9p_s22bdrc8v5gzytvxc0000gn/T/com.duckduckgo.mobile.ios.Integration-Tests/Database.sqlite. SQLite error code:6922, 'disk I/O error' with userInfo of {
|
Test (Sandbox):
CoreData#L1
-executeRequest: encountered exception = I/O error for database at /var/folders/g9/4hls9p_s22bdrc8v5gzytvxc0000gn/T/com.duckduckgo.mobile.ios.Integration-Tests/Database.sqlite. SQLite error code:6922, 'disk I/O error' with userInfo = {
|
Verify autoconsent bundle
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Make Release Build (DuckDuckGo Privacy Browser)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Make Release Build (DuckDuckGo Privacy Browser):
DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
Make Release Build (DuckDuckGo Privacy Browser):
DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
Make Release Build (DuckDuckGo Privacy Browser):
CoreData#L1
no NSValueTransformer with class name 'NSStringTransformer' was found for attribute 'titleEncrypted' on entity 'HistoryEntryManagedObject'
|
Make Release Build (DuckDuckGo Privacy Browser):
CoreData#L1
no NSValueTransformer with class name 'NSImageTransformer' was found for attribute 'faviconEncrypted' on entity 'BookmarkManagedObject'
|
Make Release Build (DuckDuckGo Privacy Browser):
DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
Make Release Build (DuckDuckGo Privacy Browser):
DuckDuckGo/Sharing/SharingMenu.swift#L77
'open(_:withAppBundleIdentifier:options:additionalEventParamDescriptor:launchIdentifiers:)' was deprecated in macOS 11.0: Use -[NSWorkspace openURLs:withApplicationAtURL:configuration:completionHandler:] instead.
|
Make Release Build (DuckDuckGo Privacy Browser):
DuckDuckGo/Sharing/SharingMenu.swift#L79
'async' was deprecated in macOS 11.0: When using NSWorkspaceOpenConfiguration, all launches are asynchronous.
|
|
Make Release Build (DuckDuckGo Privacy Browser):
DuckDuckGo/Menus/MainMenuActions.swift#L110
result of call to 'restoreLastSessionState(interactive:)' is unused
|
Make Release Build (DuckDuckGo Privacy Browser):
DuckDuckGo/NetworkProtection/AppTargets/BothAppTargets/Invite/NetworkProtectionInviteDialog.swift#L42
weak reference will always be nil because the referenced object is deallocated here
|
Make Release Build (DuckDuckGo Privacy Pro)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Make Release Build (DuckDuckGo Privacy Pro):
DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
Make Release Build (DuckDuckGo Privacy Pro):
DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
Make Release Build (DuckDuckGo Privacy Pro):
CoreData#L1
no NSValueTransformer with class name 'NSStringTransformer' was found for attribute 'titleEncrypted' on entity 'HistoryEntryManagedObject'
|
Make Release Build (DuckDuckGo Privacy Pro):
CoreData#L1
no NSValueTransformer with class name 'NSImageTransformer' was found for attribute 'faviconEncrypted' on entity 'BookmarkManagedObject'
|
Make Release Build (DuckDuckGo Privacy Pro):
DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
Make Release Build (DuckDuckGo Privacy Pro):
DuckDuckGo/Sharing/SharingMenu.swift#L77
'open(_:withAppBundleIdentifier:options:additionalEventParamDescriptor:launchIdentifiers:)' was deprecated in macOS 11.0: Use -[NSWorkspace openURLs:withApplicationAtURL:configuration:completionHandler:] instead.
|
Make Release Build (DuckDuckGo Privacy Pro):
DuckDuckGo/Sharing/SharingMenu.swift#L79
'async' was deprecated in macOS 11.0: When using NSWorkspaceOpenConfiguration, all launches are asynchronous.
|
|
Make Release Build (DuckDuckGo Privacy Pro):
DuckDuckGo/Tab/UserScripts/SubscriptionPagesUserScript.swift#L122
immutable value 'accessToken' was never used; consider replacing with '_' or removing it
|
Make Release Build (DuckDuckGo Privacy Pro):
DuckDuckGo/Menus/MainMenuActions.swift#L110
result of call to 'restoreLastSessionState(interactive:)' is unused
|
Test (Non-Sandbox)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3, mikepenz/action-junit-report@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Test (Non-Sandbox):
DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
Test (Non-Sandbox)
not stripping binary because it is signed: /Users/runner/work/macos-browser/macos-browser/DerivedData/SourcePackages/artifacts/grdb.swift/GRDB/GRDB.xcframework/macos-arm64_x86_64/GRDB.framework/Versions/A/GRDB (in target 'DataBrokerProtectionTests' from project 'DataBrokerProtection')
|
Test (Non-Sandbox):
CoreData#L1
no NSValueTransformer with class name 'NSStringTransformer' was found for attribute 'titleEncrypted' on entity 'HistoryEntryManagedObject'
|
Test (Non-Sandbox):
CoreData#L1
no NSValueTransformer with class name 'NSImageTransformer' was found for attribute 'faviconEncrypted' on entity 'BookmarkManagedObject'
|
Test (Non-Sandbox):
DuckDuckGo/Sharing/SharingMenu.swift#L77
'open(_:withAppBundleIdentifier:options:additionalEventParamDescriptor:launchIdentifiers:)' was deprecated in macOS 11.0: Use -[NSWorkspace openURLs:withApplicationAtURL:configuration:completionHandler:] instead.
|
Test (Non-Sandbox):
DuckDuckGo/Sharing/SharingMenu.swift#L79
'async' was deprecated in macOS 11.0: When using NSWorkspaceOpenConfiguration, all launches are asynchronous.
|
Test (Non-Sandbox):
DuckDuckGo/Common/Extensions/NSBezierPathExtension.swift#L30
switch must be exhaustive
|
Test (Non-Sandbox):
DuckDuckGo/Menus/MainMenuActions.swift#L110
result of call to 'restoreLastSessionState(interactive:)' is unused
|
Test (Non-Sandbox):
DerivedData/Build/Products/CI/OpenSSL.framework/Headers/shim.h#L12
a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
|
Test (Non-Sandbox):
DerivedData/Build/Products/CI/OpenSSL.framework/Headers/shim.h#L17
a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
|
Test (Non-Sandbox)
DuckDuckGoDBPBackgroundAgent isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGoDBPBackgroundAgent' from project 'DuckDuckGo')
|
Test (Non-Sandbox)
DuckDuckGoVPN isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGoVPN' from project 'DuckDuckGo')
|
Test (Non-Sandbox)
DuckDuckGo Privacy Browser isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGo Privacy Browser' from project 'DuckDuckGo')
|
Test (Non-Sandbox)
DuckDuckGoNotifications isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGoNotifications' from project 'DuckDuckGo')
|
Test (Sandbox)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3, mikepenz/action-junit-report@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Test (Sandbox)
DuckDuckGoDBPBackgroundAgentAppStore isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGoDBPBackgroundAgentAppStore' from project 'DuckDuckGo')
|
Test (Sandbox)
Run script build phase 'Copy Swift Package resources' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'DuckDuckGoDBPBackgroundAgentAppStore' from project 'DuckDuckGo')
|
Test (Sandbox)
Run script build phase 'Run Script' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'DuckDuckGoVPNAppStore' from project 'DuckDuckGo')
|
Test (Sandbox)
DuckDuckGo Privacy Browser App Store isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGo Privacy Browser App Store' from project 'DuckDuckGo')
|
Test (Sandbox)
Run script build phase 'Embed Login Items' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'DuckDuckGo Privacy Browser App Store' from project 'DuckDuckGo')
|
Test (Sandbox):
DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
Test (Sandbox):
DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
Test (Sandbox):
DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
Test (Sandbox):
CoreData#L1
no NSValueTransformer with class name 'NSStringTransformer' was found for attribute 'titleEncrypted' on entity 'HistoryEntryManagedObject'
|
Test (Sandbox):
CoreData#L1
no NSValueTransformer with class name 'NSImageTransformer' was found for attribute 'faviconEncrypted' on entity 'BookmarkManagedObject'
|
Test (Sandbox):
DuckDuckGo/Menus/MainMenuActions.swift#L110
result of call to 'restoreLastSessionState(interactive:)' is unused
|
Test (Sandbox):
DuckDuckGo/NetworkProtection/AppTargets/BothAppTargets/VPNLocation/VPNLocationPreferenceItem.swift#L62
'animation' was deprecated in macOS 12.0: Use withAnimation or animation(_:value:) instead.
|
Test (Sandbox):
DuckDuckGo/Sharing/SharingMenu.swift#L77
'open(_:withAppBundleIdentifier:options:additionalEventParamDescriptor:launchIdentifiers:)' was deprecated in macOS 11.0: Use -[NSWorkspace openURLs:withApplicationAtURL:configuration:completionHandler:] instead.
|
Test (Sandbox):
DuckDuckGo/Sharing/SharingMenu.swift#L79
'async' was deprecated in macOS 11.0: When using NSWorkspaceOpenConfiguration, all launches are asynchronous.
|
Test (Sandbox):
DuckDuckGo/Common/Extensions/NSBezierPathExtension.swift#L30
switch must be exhaustive
|
Test (Non-Sandbox)
Tests Passed: 0 failed, 0 skipped, 202 total (13.764 seconds)
|
Test (Sandbox)
Tests Passed: 0 failed, 0 skipped, 9 total (0.112 seconds)
|