Implement tab bar remote message #14733
Annotations
10 errors, 12 warnings, and 7 notices
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x1647ef470> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600002660bb0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x40cf77690> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600002670790> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x128777c00> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000267f5a0> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x128596060> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000065f0dc0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x40eb43420> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000065ccb00> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x40eefd960> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000065f2470> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x12a086520> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000065c8a50> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x40cf1dcd0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000267d290> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x40cb917c0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600006606e10> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x1398c6920> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000025902c0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x1384c0e80> should deallocate", "<DuckDuckGo_WebView: 0x13842a830> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40cf76650> should deallocate", "<DuckDuckGo_WebView: 0x40cf98ac0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x163021900> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600006688210> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x1633ae890> should deallocate", "<DuckDuckGo_WebView: 0x1633b0bb0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40cf9dfe0> should deallocate", "<DuckDuckGo_WebView: 0x40cf9e930> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x40cbe48f0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000066465d0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40cf5cb30> should deallocate", "<DuckDuckGo_WebView: 0x40cf5cd90> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x166d3ce60> should deallocate", "<DuckDuckGo_WebView: 0x166d3d500> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x11f5a6800> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000267ff40> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x1386a53d0> should deallocate", "<DuckDuckGo_WebView: 0x128795bb0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40fd17f80> should deallocate", "<DuckDuckGo_WebView: 0x138473680> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x139ab1670> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000065f8840> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x16393d610> should deallocate", "<DuckDuckGo_WebView: 0x1639d8d50> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x1630fb5d0> should deallocate", "<DuckDuckGo_WebView: 0x1630fc040> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x40f5f9260> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000665a050> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40eeebb90> should deallocate", "<DuckDuckGo_WebView: 0x40ee31400> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x163045290> should deallocate", "<DuckDuckGo_WebView: 0x163045940> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x1676a8a50> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000066a9c30> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x13879f770> should deallocate", "<DuckDuckGo_WebView: 0x40f570020> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40cf7d7c0> should deallocate", "<DuckDuckGo_WebView: 0x40cf7e140> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x40eec0590> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600006582680> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x1639befb0> should deallocate", "<DuckDuckGo_WebView: 0x1639c22d0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x1633257c0> should deallocate", "<DuckDuckGo_WebView: 0x1670051e0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x16304f130> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000065a5760> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x1639a8db0> should deallocate", "<DuckDuckGo_WebView: 0x1639b1a70> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x16339dff0> should deallocate", "<DuckDuckGo_WebView: 0x1633991e0> should deallocate".
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/History/HistoryIntegrationTests.swift#L219
testWhenScriptTrackerLoaded_trackerAddedToHistory, failed: caught error: "Timeout"
|
Upload failed unit tests xcresult
No files were found with the provided path: Non-Sandbox-unittests.xcresult. No artifacts will be uploaded.
|
Run integration tests
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
|
Build and run unit tests:
LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L179
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L173
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L326
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L322
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/SubscriptionUI/Sources/SubscriptionUI/DebugMenu/DebugPurchaseView.swift#L167
extension declares a conformance of imported type 'String' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
Build and run unit tests:
DerivedData/Build/Products/CI/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
|
Build and run unit tests:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/NetworkProtectionTokenStore+SubscriptionTokenKeychainStorage.swift#L25
extension declares a conformance of imported type 'NetworkProtectionKeychainTokenStore' to imported protocol 'SubscriptionTokenStoring'; this will not behave correctly if the owners of 'NetworkProtection' introduce this conformance in the future
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testFeatureDisabledAndPhishingDetection_tabIsNotMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingDetected_tabIsMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingDetectedThenDDGLoaded_tabIsNotMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingDetectedThenNotDetected_tabIsNotMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingDetectedViaHTTPRedirectChain_tabIsMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingDetectedViaJSRedirectChain_tabIsMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingNotDetected_tabIsNotMarkedPhishing
|
Loading