Implement tab bar remote message #14733
Annotations
10 errors, 12 warnings, and 5 notices
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x178655830> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000172a9f0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x4052e8ab0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000054e1970> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x163d92600> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000054f6260> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x17ff8e3d0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600001773440> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x163de2110> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000054cf2e0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x166cf4e70> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000054ca3c0> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x12da24c60> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000017e04d0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x17486b3b0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000017ff230> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x1780e4060> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600001770210> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x17ff2b600> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000054b8e70> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x106e9e630> should deallocate", "<DuckDuckGo_WebView: 0x175de5090> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x1780b9360> should deallocate", "<DuckDuckGo_WebView: 0x12d8b4300> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x163d93c80> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000054ce680> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x166c632f0> should deallocate", "<DuckDuckGo_WebView: 0x166c64bc0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40424a850> should deallocate", "<DuckDuckGo_WebView: 0x4042b0370> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x402067fd0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600001772890> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x4042546b0> should deallocate", "<DuckDuckGo_WebView: 0x1786f6b40> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x4020be880> should deallocate", "<DuckDuckGo_WebView: 0x4020bf050> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x12bb385e0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000017e1080> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x1748dc270> should deallocate", "<DuckDuckGo_WebView: 0x1748e2140> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x106e7b810> should deallocate", "<DuckDuckGo_WebView: 0x175d93f50> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x12bb954c0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600001773020> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x166c83260> should deallocate", "<DuckDuckGo_WebView: 0x166c83de0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x406622320> should deallocate", "<DuckDuckGo_WebView: 0x17804d890> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x12c747b60> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000140b5a0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x4020698f0> should deallocate", "<DuckDuckGo_WebView: 0x40206cd40> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x175def5b0> should deallocate", "<DuckDuckGo_WebView: 0x175defd80> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x12c7126f0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000054b6100> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x166c8f820> should deallocate", "<DuckDuckGo_WebView: 0x166c82eb0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x402035a30> should deallocate", "<DuckDuckGo_WebView: 0x407ff0030> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x166c5a990> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000054b5c30> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x402080d80> should deallocate", "<DuckDuckGo_WebView: 0x402066b80> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40664de20> should deallocate", "<DuckDuckGo_WebView: 0x40664ec80> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x4020b7f10> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000143e3c0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x402084c50> should deallocate", "<DuckDuckGo_WebView: 0x40203f8e0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x4063925a0> should deallocate", "<DuckDuckGo_WebView: 0x406392e70> should deallocate".
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/History/HistoryIntegrationTests.swift#L219
testWhenScriptTrackerLoaded_trackerAddedToHistory, failed: caught error: "Timeout"
|
Run integration tests
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
|
Upload failed unit tests xcresult
No files were found with the provided path: Sandbox-unittests.xcresult. No artifacts will be uploaded.
|
Build and run unit tests:
LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L179
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L173
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L326
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L322
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Run integration tests
Skipped Integration_Tests_App_Store.DownloadsIntegrationTests.testWhenLocalFile_downloadStartsAlwaysDisplayingSavePanel
|
Run integration tests
Skipped Integration_Tests_App_Store.MaliciousSiteProtectionIntegrationTests.testFeatureDisabledAndPhishingDetection_tabIsNotMarkedPhishing
|
Run integration tests
Skipped Integration_Tests_App_Store.MaliciousSiteProtectionIntegrationTests.testPhishingDetected_tabIsMarkedPhishing
|
Run integration tests
Skipped Integration_Tests_App_Store.MaliciousSiteProtectionIntegrationTests.testPhishingDetectedThenDDGLoaded_tabIsNotMarkedPhishing
|
Run integration tests
Skipped Integration_Tests_App_Store.MaliciousSiteProtectionIntegrationTests.testPhishingDetectedViaHTTPRedirectChain_tabIsMarkedPhishing
|
Loading