Implement tab bar remote message #14731
Annotations
10 errors, 12 warnings, and 7 notices
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x13a7b9da0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000315dc30> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x410a51be0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000316d760> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x14fa0c1d0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000324ee10> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x14bfb8420> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600003178a50> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x12ae07680> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000317e470> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x1597ee630> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000725c580> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x138030160> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000317af70> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x14afa3990> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000725e050> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x14bb39e40> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000031639c0> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x14b8e6010> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000312c000> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x14fadb310> should deallocate", "<DuckDuckGo_WebView: 0x15ae0fb10> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x15ae16420> should deallocate", "<DuckDuckGo_WebView: 0x15ae2cf10> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x1597d92e0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600007214c60> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x16f7fb930> should deallocate", "<DuckDuckGo_WebView: 0x16f7fbe90> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x15ae176c0> should deallocate", "<DuckDuckGo_WebView: 0x13a7b3a30> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x14ff5c7d0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000316def0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x15af6f430> should deallocate", "<DuckDuckGo_WebView: 0x15af9fd10> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x15af4e0e0> should deallocate", "<DuckDuckGo_WebView: 0x15af4e780> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x14fb72f20> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600003178c60> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x13a7b3dc0> should deallocate", "<DuckDuckGo_WebView: 0x13a7ca660> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x14ffdda80> should deallocate", "<DuckDuckGo_WebView: 0x14ff9afb0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x16407a100> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600007228000> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x13a6dccb0> should deallocate", "<DuckDuckGo_WebView: 0x159770f50> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x41714e250> should deallocate", "<DuckDuckGo_WebView: 0x41714ead0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x1640b0360> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600007217440> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x1640b46a0> should deallocate", "<DuckDuckGo_WebView: 0x1640ae820> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x405d752f0> should deallocate", "<DuckDuckGo_WebView: 0x405d75990> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x14fabcfe0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600007207d30> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x16f719de0> should deallocate", "<DuckDuckGo_WebView: 0x16f71a280> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x417431720> should deallocate", "<DuckDuckGo_WebView: 0x41744e380> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x410a46580> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600003164630> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x417424a00> should deallocate", "<DuckDuckGo_WebView: 0x417448610> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x41727a6e0> should deallocate", "<DuckDuckGo_WebView: 0x41727b240> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x14fffa610> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000312f440> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x41741c290> should deallocate", "<DuckDuckGo_WebView: 0x41741c730> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x163f94520> should deallocate", "<DuckDuckGo_WebView: 0x163f94cc0> should deallocate".
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/History/HistoryIntegrationTests.swift#L219
testWhenScriptTrackerLoaded_trackerAddedToHistory, failed: caught error: "Timeout"
|
Upload failed unit tests xcresult
No files were found with the provided path: Non-Sandbox-unittests.xcresult. No artifacts will be uploaded.
|
Run integration tests
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
|
Build and run unit tests:
LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L179
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L173
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L326
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L322
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/SubscriptionUI/Sources/SubscriptionUI/DebugMenu/DebugPurchaseView.swift#L167
extension declares a conformance of imported type 'String' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
Build and run unit tests:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/NetworkProtectionTokenStore+SubscriptionTokenKeychainStorage.swift#L25
extension declares a conformance of imported type 'NetworkProtectionKeychainTokenStore' to imported protocol 'SubscriptionTokenStoring'; this will not behave correctly if the owners of 'NetworkProtection' introduce this conformance in the future
|
Build and run unit tests:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L135
'VPNLogger' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testFeatureDisabledAndPhishingDetection_tabIsNotMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingDetected_tabIsMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingDetectedThenDDGLoaded_tabIsNotMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingDetectedThenNotDetected_tabIsNotMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingDetectedViaHTTPRedirectChain_tabIsMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingDetectedViaJSRedirectChain_tabIsMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingNotDetected_tabIsNotMarkedPhishing
|
Loading