Implement tab bar remote message #14731
Annotations
10 errors, 12 warnings, and 2 notices
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x409aaab90> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600007014000> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x409af1410> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600007362680> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x405747b20> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000735a890> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x132b9cfc0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000735d970> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x17126a330> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000030529f0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x4038117e0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000073b8210> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x132b1c020> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600007344790> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x409a8c190> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600007346b50> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x1717e2bc0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600007354630> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x132a46c10> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000073ac2c0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x117b5f060> should deallocate", "<DuckDuckGo_WebView: 0x4038bb730> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x409e6fef0> should deallocate", "<DuckDuckGo_WebView: 0x409ec2300> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x132826dc0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000073b46e0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x408d42190> should deallocate", "<DuckDuckGo_WebView: 0x408dc4810> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x1712dc040> should deallocate", "<DuckDuckGo_WebView: 0x17126c480> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x422af2e30> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000073b0370> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x409e71e10> should deallocate", "<DuckDuckGo_WebView: 0x409e75fa0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x171262b70> should deallocate", "<DuckDuckGo_WebView: 0x171263220> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x117bc6aa0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000030e2ec0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x405436ec0> should deallocate", "<DuckDuckGo_WebView: 0x409efcd00> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x176276c50> should deallocate", "<DuckDuckGo_WebView: 0x176276ff0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x402525c40> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600007342e10> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x17471da80> should deallocate", "<DuckDuckGo_WebView: 0x17471e1e0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x17bc15c70> should deallocate", "<DuckDuckGo_WebView: 0x17bc1aa60> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x17174f420> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000030e1290> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x4025cd3a0> should deallocate", "<DuckDuckGo_WebView: 0x4025cba00> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x1717f6770> should deallocate", "<DuckDuckGo_WebView: 0x1717f6f40> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x405484440> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000030e7bd0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x1717a3e90> should deallocate", "<DuckDuckGo_WebView: 0x4054d5ff0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x1762f0810> should deallocate", "<DuckDuckGo_WebView: 0x1762f0d70> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x402580b80> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000070a8d10> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x117e0ec90> should deallocate", "<DuckDuckGo_WebView: 0x408d14160> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x1712eb6b0> should deallocate", "<DuckDuckGo_WebView: 0x17121f3d0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x17177f640> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000030ed1e0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x1717772b0> should deallocate", "<DuckDuckGo_WebView: 0x17177c980> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x1747b99a0> should deallocate", "<DuckDuckGo_WebView: 0x1747ba450> should deallocate".
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/History/HistoryIntegrationTests.swift#L219
testWhenScriptTrackerLoaded_trackerAddedToHistory, failed: caught error: "Timeout"
|
Run integration tests
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
|
Upload failed unit tests xcresult
No files were found with the provided path: Sandbox-unittests.xcresult. No artifacts will be uploaded.
|
Build and run unit tests:
LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L179
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L173
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L326
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L322
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Run integration tests
Skipped Integration_Tests_App_Store.DownloadsIntegrationTests.testWhenLocalFile_downloadStartsAlwaysDisplayingSavePanel
|
Run integration tests
Skipped Integration_Tests_App_Store.MaliciousSiteProtectionIntegrationTests.testPhishingDetected_tabIsMarkedPhishing
|
Loading