Implement tab bar remote message #14730
Annotations
10 errors, 12 warnings, and 7 notices
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x406d0aba0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000015d0420> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x14f11fa10> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000015c5970> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x16ffdd0e0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000015dce70> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x4086c9e90> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000563c8f0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x14debed70> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000015c0fd0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x165c83ec0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600005634840> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x14dffb4d0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000160e7e0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x409288f00> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000015c3f40> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x14decd140> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600001623230> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x165c0bfe0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000015ec210> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x14f3fc550> should deallocate", "<DuckDuckGo_WebView: 0x14f3ca920> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40b5d86a0> should deallocate", "<DuckDuckGo_WebView: 0x40b5d8900> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x165cbd4b0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000056313f0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x408652b90> should deallocate", "<DuckDuckGo_WebView: 0x408618640> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x4091558b0> should deallocate", "<DuckDuckGo_WebView: 0x409156320> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x405768f30> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000015ebe90> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x16d6c62b0> should deallocate", "<DuckDuckGo_WebView: 0x16d6c9ef0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x4000ebd10> should deallocate", "<DuckDuckGo_WebView: 0x4000eeb00> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x165cb84e0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600001695d90> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x409207c20> should deallocate", "<DuckDuckGo_WebView: 0x4006c3580> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x16d6da690> should deallocate", "<DuckDuckGo_WebView: 0x16d6d4210> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x40b5d5ac0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000563e520> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40b5d26b0> should deallocate", "<DuckDuckGo_WebView: 0x40b5d1d80> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x16d6ca760> should deallocate", "<DuckDuckGo_WebView: 0x16d6c5f00> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x409291140> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600001616940> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x409241fb0> should deallocate", "<DuckDuckGo_WebView: 0x4092fee70> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40001e770> should deallocate", "<DuckDuckGo_WebView: 0x14f2cf650> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x13d1efea0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000015c11e0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x14de164f0> should deallocate", "<DuckDuckGo_WebView: 0x14de194e0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x406dda890> should deallocate", "<DuckDuckGo_WebView: 0x16d6bd120> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x400045320> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000015eb020> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x406da5070> should deallocate", "<DuckDuckGo_WebView: 0x14f3a2910> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x408ba3ff0> should deallocate", "<DuckDuckGo_WebView: 0x408ba4b60> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x408ba2bd0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000015d2520> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x1629dcb60> should deallocate", "<DuckDuckGo_WebView: 0x1629d6750> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x406db62f0> should deallocate", "<DuckDuckGo_WebView: 0x406db73f0> should deallocate".
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/History/HistoryIntegrationTests.swift#L219
testWhenScriptTrackerLoaded_trackerAddedToHistory, failed: caught error: "Timeout"
|
Upload failed unit tests xcresult
No files were found with the provided path: Non-Sandbox-unittests.xcresult. No artifacts will be uploaded.
|
Run integration tests
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
|
Build and run unit tests:
LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L179
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L173
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L326
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L322
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/SubscriptionUI/Sources/SubscriptionUI/DebugMenu/DebugPurchaseView.swift#L167
extension declares a conformance of imported type 'String' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
Build and run unit tests:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/NetworkProtectionTokenStore+SubscriptionTokenKeychainStorage.swift#L25
extension declares a conformance of imported type 'NetworkProtectionKeychainTokenStore' to imported protocol 'SubscriptionTokenStoring'; this will not behave correctly if the owners of 'NetworkProtection' introduce this conformance in the future
|
Build and run unit tests:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L135
'VPNLogger' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testFeatureDisabledAndPhishingDetection_tabIsNotMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingDetected_tabIsMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingDetectedThenDDGLoaded_tabIsNotMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingDetectedThenNotDetected_tabIsNotMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingDetectedViaHTTPRedirectChain_tabIsMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingDetectedViaJSRedirectChain_tabIsMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingNotDetected_tabIsNotMarkedPhishing
|
Loading