Implement tab bar remote message #14730
Annotations
10 errors, 12 warnings, and 5 notices
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x17bc42ba0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000007e9130> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x40637b280> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000007e5c30> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x172648650> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000044d48f0> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x401f6d7b0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000007f2470> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x124789710> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000007ea100> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x407b64ad0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000007b6c00> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x172c0c850> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000079e9f0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x126176720> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000078ce70> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x408b38060> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000007e9550> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x107c736b0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000007f16b0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x107106fc0> should deallocate", "<DuckDuckGo_WebView: 0x107159a70> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x17644fa00> should deallocate", "<DuckDuckGo_WebView: 0x17644de50> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x124784810> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000007bab50> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x1247775a0> should deallocate", "<DuckDuckGo_WebView: 0x17bc1cc90> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x1743f3ef0> should deallocate", "<DuckDuckGo_WebView: 0x1743f4a70> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x172534200> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000007f08f0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x176444b30> should deallocate", "<DuckDuckGo_WebView: 0x1764451e0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x17147cdb0> should deallocate", "<DuckDuckGo_WebView: 0x173facff0> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x1260f66b0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000044d98c0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x4063a35a0> should deallocate", "<DuckDuckGo_WebView: 0x406370c20> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x173fadd00> should deallocate", "<DuckDuckGo_WebView: 0x173f843b0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x407ba1010> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600000788420> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x407b53d80> should deallocate", "<DuckDuckGo_WebView: 0x407b9f5b0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x1726ffa50> should deallocate", "<DuckDuckGo_WebView: 0x1764cb710> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x17643e8c0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000007e3230> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x173f6f370> should deallocate", "<DuckDuckGo_WebView: 0x173f17b40> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x408cc3770> should deallocate", "<DuckDuckGo_WebView: 0x408cc3f40> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x171405550> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000007b9fa0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x1261f26b0> should deallocate", "<DuckDuckGo_WebView: 0x12612c820> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x408b4d6f0> should deallocate", "<DuckDuckGo_WebView: 0x408bca440> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x1726dffc0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000444ba70> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x1726e3350> should deallocate", "<DuckDuckGo_WebView: 0x1726e3ff0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x17656ce20> should deallocate", "<DuckDuckGo_WebView: 0x17656dac0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x408c1c560> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000007849a0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x1725a7fa0> should deallocate", "<DuckDuckGo_WebView: 0x174390920> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x408c477d0> should deallocate", "<DuckDuckGo_WebView: 0x408c480a0> should deallocate".
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/History/HistoryIntegrationTests.swift#L219
testWhenScriptTrackerLoaded_trackerAddedToHistory, failed: caught error: "Timeout"
|
Run integration tests
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
|
Upload failed unit tests xcresult
No files were found with the provided path: Sandbox-unittests.xcresult. No artifacts will be uploaded.
|
Build and run unit tests:
LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L179
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L173
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L326
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L322
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Run integration tests
Skipped Integration_Tests_App_Store.DownloadsIntegrationTests.testWhenLocalFile_downloadStartsAlwaysDisplayingSavePanel
|
Run integration tests
Skipped Integration_Tests_App_Store.MaliciousSiteProtectionIntegrationTests.testFeatureDisabledAndPhishingDetection_tabIsNotMarkedPhishing
|
Run integration tests
Skipped Integration_Tests_App_Store.MaliciousSiteProtectionIntegrationTests.testPhishingDetected_tabIsMarkedPhishing
|
Run integration tests
Skipped Integration_Tests_App_Store.MaliciousSiteProtectionIntegrationTests.testPhishingDetectedThenDDGLoaded_tabIsNotMarkedPhishing
|
Run integration tests
Skipped Integration_Tests_App_Store.MaliciousSiteProtectionIntegrationTests.testPhishingDetectedViaHTTPRedirectChain_tabIsMarkedPhishing
|
Loading