Credential provider QuickType support #3696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… vault in main Passwords screen also
…ync with lastUsed passwords
…nsion is included
|
6 tasks
amddg44
commented
Dec 9, 2024
| override func provideCredentialWithoutUserInteraction(for credentialIdentity: ASPasswordCredentialIdentity) { | ||
| // A quirk here is calling .canAuthenticate in this one scenario actually triggers the prompt to authentication | ||
| // Calling .authenticate here results in the extension attempting to present a non-existent view controller causing weird UI | ||
| if authenticator.canAuthenticateViaBiometrics() { |
There was a problem hiding this comment.
If biometrics authentication is not possible (or no device auth is set), userInteractionRequired is returned here. This triggers a call to prepareInterfaceToProvideCredential(for credentialRequest: any ASCredentialRequest) which presents a lock screen UI and complete authentication & error handling
aataraxiaa
approved these changes
Dec 9, 2024
amddg44
merged commit 4881936
into
feature/system-credential-provider
12 of 13 checks passed
amddg44
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Dec 9, 2024
Task/Issue URL: iOS PR: duckduckgo/iOS#3696 macOS PR: duckduckgo/macos-browser#3648 What kind of version bump will this require?: Minor **Description**: Adds support for QuickType to the Credential provider extension along with deduplication logic
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL:
Tech Design URL:
CC:
Description:
Adds support for QuickType to the Credential provider extension (along with deduplication logic for the QuickType prompts)
Steps to test this PR:
https://autofill.me/form/login-simple. Also add one with a duplicate username and password, but with a different subdomain e.g.test.autofill.meautofill.mein Safari<!—
Before submitting a PR, please ensure you have tested the combinations you expect the reviewer to test, then delete configurations you know do not need explicit testing.
Using a simulator where a physical device is unavailable is acceptable.
—>
Definition of Done (Internal Only):
Copy Testing:
’rather than’Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
—
Internal references:
Software Engineering Expectations
Technical Design Template