duckduckgo · samsymons · Nov 15, 2024 · Sep 20, 2024 · Sep 21, 2024 · Sep 25, 2024
diff --git a/.github/workflows/end-to-end.yml b/.github/workflows/end-to-end.yml
@@ -42,7 +42,7 @@ jobs:
       run: |
         set -o pipefail && xcodebuild \
           -scheme "DuckDuckGo" \
-          -destination "platform=iOS Simulator,name=iPhone 15,OS=17.2" \
+          -destination "platform=iOS Simulator,name=iPhone 16,OS=18.1" \
           -derivedDataPath "DerivedData" \
           -skipPackagePluginValidation \
           -skipMacroValidation \

diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml
@@ -44,7 +44,7 @@ jobs:
       run: |
         set -o pipefail && xcodebuild test \
           -scheme "AtbUITests" \
-          -destination "platform=iOS Simulator,name=iPhone 15,OS=17.2" \
+          -destination "platform=iOS Simulator,name=iPhone 16,OS=18.1" \
           -derivedDataPath "DerivedData" \
           -skipPackagePluginValidation \
           -skipMacroValidation \
@@ -87,7 +87,7 @@ jobs:
       run: |
         set -o pipefail && xcodebuild test \
           -scheme "FingerprintingUITests" \
-          -destination "platform=iOS Simulator,name=iPhone 15,OS=17.2" \
+          -destination "platform=iOS Simulator,name=iPhone 16,OS=18.1" \
           -derivedDataPath "DerivedData" \
           -skipPackagePluginValidation \
           -skipMacroValidation \

diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml
@@ -39,7 +39,7 @@ jobs:
 
     name: Unit Tests
 
-    runs-on: macos-14-xlarge
+    runs-on: macos-15
     timeout-minutes: 20
 
     outputs:
@@ -79,7 +79,7 @@ jobs:
       run: |
         set -o pipefail && xcodebuild test \
           -scheme "DuckDuckGo" \
-          -destination "platform=iOS Simulator,name=iPhone 15,OS=17.2" \
+          -destination "platform=iOS Simulator,name=iPhone 16,OS=18.1" \
           -derivedDataPath "DerivedData" \
           -skipPackagePluginValidation \
           -skipMacroValidation \
@@ -132,7 +132,7 @@ jobs:
     # Dependabot doesn't have access to all secrets, so we skip this job
     if: github.actor != 'dependabot[bot]'
 
-    runs-on: macos-14-xlarge
+    runs-on: macos-15
     timeout-minutes: 30
 
     steps:
@@ -185,7 +185,7 @@ jobs:
 
         set -o pipefail && xcodebuild \
         -scheme "DuckDuckGo" \
-        -destination "platform=iOS Simulator,name=iPhone 15" \
+        -destination "platform=iOS Simulator,name=iPhone 16" \
         -derivedDataPath "DerivedData" \
         -configuration "Release" \
         -skipPackagePluginValidation \

diff --git a/.github/workflows/sync-end-to-end.yml b/.github/workflows/sync-end-to-end.yml
@@ -42,7 +42,7 @@ jobs:
       run: |
         set -o pipefail && xcodebuild \
           -scheme "DuckDuckGo" \
-          -destination "platform=iOS Simulator,name=iPhone 15" \
+          -destination "platform=iOS Simulator,name=iPhone 16" \
           -derivedDataPath "DerivedData" \
           -skipPackagePluginValidation \
           -skipMacroValidation \

diff --git a/.../data_clearing_tests/01_fire_proofing.yml → ...data_clearing_tests/01_fire_proofing.yaml b/.../data_clearing_tests/01_fire_proofing.yml → ...data_clearing_tests/01_fire_proofing.yaml
diff --git a/...clearing_tests/02_duckduckgo_settings.yml → ...learing_tests/02_duckduckgo_settings.yaml b/...clearing_tests/02_duckduckgo_settings.yml → ...learing_tests/02_duckduckgo_settings.yaml
diff --git a/.maestro/setup_ui_tests.sh b/.maestro/setup_ui_tests.sh
@@ -7,8 +7,8 @@ source $(dirname $0)/common.sh
 ## Constants
 
 # The simulator command requires the hyphens
-target_device="iPhone-15"
-target_os="iOS-17-0"
+target_device="iPhone-16"
+target_os="iOS-18-1"
 
 ## Functions
 
@@ -50,7 +50,7 @@ build_app() {
     echo "⏲️ Building the app"
     set -o pipefail && xcodebuild -project "$project_root"/DuckDuckGo.xcodeproj \
                                   -scheme "DuckDuckGo" \
-                                  -destination "platform=iOS Simulator,name=iPhone 15,OS=17.2" \
+                                  -destination "platform=iOS Simulator,name=iPhone 16,OS=18.1" \
                                   -derivedDataPath "$derived_data_path" \
                                   -skipPackagePluginValidation \
                                   -skipMacroValidation \

diff --git a/.maestro/shared/remove_local_logins.yaml b/.maestro/shared/remove_local_logins.yaml
@@ -2,6 +2,8 @@ appId: com.duckduckgo.mobile.ios
 ---
 
 - tapOn: Settings
+- scrollUntilVisible:
+    element: Passwords
 - tapOn: Passwords
 - tapOn: Passcode field
 - inputText: "0000"
@@ -10,4 +12,4 @@ appId: com.duckduckgo.mobile.ios
 - tapOn: Delete Password
 - tapOn: Delete Password
 - tapOn: Settings
-- tapOn: Done
+- tapOn: Done
diff --git a/.xcode-version b/.xcode-version
@@ -1 +1 @@
-15.4
+16.1
diff --git a/DuckDuckGo.xcodeproj/project.pbxproj b/DuckDuckGo.xcodeproj/project.pbxproj
@@ -10991,8 +10991,8 @@
 			isa = XCRemoteSwiftPackageReference;
 			repositoryURL = "https://github.com/DuckDuckGo/BrowserServicesKit";
 			requirement = {
-				kind = exactVersion;
-				version = 209.0.0;
+				branch = "dominik/xcode-16";
+				kind = branch;
 			};
 		};
 		9F8FE9472BAE50E50071E372 /* XCRemoteSwiftPackageReference "lottie-spm" */ = {

diff --git a/DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved b/DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@@ -32,8 +32,8 @@
       "kind" : "remoteSourceControl",
       "location" : "https://github.com/DuckDuckGo/BrowserServicesKit",
       "state" : {
-        "revision" : "614ea57db48db644ce7f3a3de9c20c9a7fbb08ff",
-        "version" : "209.0.0"
+        "branch" : "dominik/xcode-16",
+        "revision" : "722c0b352c957e81c555d45a6fe1b8941aaf99a8"
       }
     },
     {

diff --git a/DuckDuckGoTests/ContextualDaxDialogsFactoryTests.swift b/DuckDuckGoTests/ContextualDaxDialogsFactoryTests.swift
@@ -452,7 +452,7 @@ extension ContextualDaxDialogsFactoryTests {
         XCTAssertNotNil(host.view)
 
         // THEN
-        waitForExpectations(timeout: 2.0)
+        waitForExpectations(timeout: 10.0)
         completionHandler()
     }