Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Xcode 16 #3573

Merged
merged 34 commits into from
Nov 15, 2024
Merged

Upgrade to Xcode 16 #3573

merged 34 commits into from
Nov 15, 2024

Conversation

samsymons
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/1203301625297703/1208329354262556/f

This PR upgrades the app to support Xcode 16.

Steps to test this PR:

  1. Check that CI is green and that this branch works locally when running on Xcode 16

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme
Internal references:

Software Engineering Expectations
Technical Design Template

ayoy and others added 30 commits September 21, 2024 13:01
@ayoy
Update supported Xcode version to 16.0
12b1ff4
@ayoy
Update BSK
eee242f
@ayoy
Update BSK ref
2e490c5
@ayoy
Merge branch 'main' into dominik/xcode-16
9509c67
@diegoreymendez
Increases the wait time for a breaking test (#3419)
966c1ab 
Task/Issue URL: https://app.asana.com/0/0/1208389158134600/f

## Description

Increases the wait time for a breaking test. Locally the test works just
fine so I'm guessing it's something with the CI making the test slower.
@ayoy
Update BSK ref
f67e7f2
@samsymons
Merge branch 'main' into dominik/xcode-16
7d6ad39 
# By Daniel Bernal (4) and others
# Via Daniel Bernal (1) and others
* main:
  Pixel retrying (#3358)
  Remove `voiceSearchHelper` from `AppDependencyProvider` (#3452)
  Update AutoClearSettingsViewController to use DI for app settings (#3448)
  Bump BSK (#3441)
  Remove `SubscriptionFeatureAvailability` from `AppDependencyProvider` (#3447)
  Release 7.141.0-2 (#3451)
  Do not notify the FE on experiment activation (#3450)
  point to bsk branch (#3444)
  bump bsk for content blocker rules fix (#3445)
  speculative fix for set bars visibility crashes (#3442)
  Release 7.141.0-1 (#3443)
  Fix browsing menu bottom offset when bar location set to bottom (#3440)
  Properly handle responses that should trigger download action (#3407)
  Add Events Firing for Phishing Detection Settings: Point to BSK (#3423)
  DuckPlayer: Temporary Fix for Watch In Youtube (#3437)
  Add 'Open in New Tab' support for DuckPlayer (#3431)
  update BSK dependency (#3434)
  Release 7.141.0-0 (#3435)
  Add error handling to contrainer removal (#3424)
  Prevent autofill prompt crash for edge case where a context menu is also visible on screen (#3417)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@samsymons
Update BSK reference.
0239e19
@samsymons
Merge branch 'main' into dominik/xcode-16
4c98e85 
# By Mariusz Śpiewak (3) and others
# Via Elle Sullivan (2) and others
* main: (26 commits)
  Release 7.143.0-0 (#3497)
  Fix the condition (#3496)
  Use cookie to share subscription access token on DDG domains (#3488)
  Show VPN onboarding tips (#3429)
  TestFlight only release and promotion (#3474)
  point to BSK branch (#3492)
  Remove Recovered References (#3457)
  Fix image set warning (#3459)
  Make running the script more explicit (#3484)
  Add pixel when the error page is shown (#3487)
  Release 7.142.0-1 (#3483)
  Merge Hotfix/7.141.1 into 7.142.0 release branch (#3481)
  Release 7.141.1-0 (#3479)
  Handle 'data' scheme downloads through WebKit's `decisionHandler(.download)` (#3478)
  Email parsing improved (#3436)
  Fix updating OmniBar constraints on iOS18 (#3473)
  For BLOB downloads make sure the file is not preview-able before triggering the download (#3472)
  Set UserDefaults API access reason to 1C8F.1 (#3475)
  Bump BSK to the version with newTabSearchField feature flag (#3449)
  Use New Tab Page implementation without customization features (#3453)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@samsymons
Update BSK reference.
6dabf71
@samsymons
Set Xcode version to 16.1.
17abbed
@samsymons
Merge branch 'main' into dominik/xcode-16
0865e5e 
* main:
  adding impression pixels for duckplayer in landscape mode (#3493)
  Update autoconsent to v10.17.0 (#3504)
  Onboarding Add to Dock Tutorial (#3482)
  Blind attempt to fix Omnibar-related crash (#3500)
  Add to Dock Localised strings (#3494)
  Add to Dock Onboarding feature flag (#3476)
  Remove HomePageViewController code (#3454)
@samsymons
Update Maestro simulator version for 16.1.
4729ee6
@samsymons
Fix iOS 18 widget UI tests.
bac8b98
@samsymons
Rename data clearing test files to match others & work with run script.
4c27522
@samsymons
Scroll down to the Passwords row correctly.
aa55e99
@samsymons
Merge branch 'main' into dominik/xcode-16
22a19c9 
# By Daniel Bernal (7) and others
# Via Daniel Bernal (3) and others
* main: (29 commits)
  Send pixel on sync secure storage failure (#3542)
  Onboarding Add to Dock Refactor for Intro scenario (#3538)
  Update C-S-S to 6.29.0 (#3541)
  Change save password Never for Site button to Not Now (#3471)
  Release 7.144.0-1 (#3540)
  UserDefaults misbehavior monitoring (#3510)
  Send pixel on sync secure storage read failure (#3530)
  Remove NewTabPage retain cycles (#3532)
  Update release notes (#3529)
  Release 7.144.0-0 (#3528)
  Add Privacy Config feature to control ad attribution reporting (#3506)
  Validate VPN errors before re-throwing them (#3513)
  Allowing users to delete suggestions on macOS (#3465)
  Update build number
  Update build number
  Bump rexml from 3.3.8 to 3.3.9 (#3495)
  Release 7.142.1-1 (#3525)
  Add a debouncer to NavBars animator (#3519)
  Release 7.143.0-1 (#3516)
  Update to subscription cookie (#3512)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@samsymons
Update BSK reference.
d695208
@samsymons
Merge branch 'main' into dominik/xcode-16
737619b 
# By Sam Symons (5) and others
# Via GitHub
* main:
  Remove VPN test rollout pixel (#3536)
  VPN clean-up (#3502)
  add daily pixel for deleting suggestions (#3531)
  Fix VPN memory pressure monitor (#3535)
  Update Ruby to 3.3.4 (#3547)
  Onboarding Add To Dock Pixels (#3543)
  Switch to free runners for tests that run on Maestro (#3546)
  Fix email protection test (#3539)
  Update BSK for PixelKit suffix change (#3534)
  Adding app backgrounded result to rule compilation (#3533)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
#	DuckDuckGoTests/ContextualDaxDialogsFactoryTests.swift
@samsymons
Update BSK.
313907c
@samsymons
Use 18.1 simulators.
a492a86
@samsymons
Merge branch 'main' into dominik/xcode-16
d092e00 
# By Alessandro Boron (1) and bwaresiak (1)
# Via GitHub
* main:
  Update Attribution logic to fix state issues  (#3548)
  Update Add To Dock copy (#3549)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@samsymons
Update BSK reference.
5438704
@samsymons
Remove iOS 18 from the sync E2E tests.
6d8e563
@samsymons
Set the widget tests back to iOS 17.
3cad996
@samsymons
Merge branch 'main' into dominik/xcode-16
edf5dca 
# By Daniel Bernal (1) and others
# Via Federico Cappelli (1) and GitHub (1)
* main:
  Remediate TunnelVision, TunnelCrack and fix "Exclude Local Networks" (#3460)
  Sync: Send pixels for account removal + decoding issues (#3557)
  Release 7.145.0-0 (#3560)
  [DuckPlayer] Base Overlay Pixel Implementation (#3545)
  Refresh toast updates (#3552)
  point to BSK branch (#3559)
  Remove ATB from attribution pixel (#3550)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@samsymons
Update BSK reference.
045e596
@samsymons
Merge branch 'main' into dominik/xcode-16
7f9ac0e 
* main:
  Release 7.145.0-2 (#3570)
  Fix favorites grid layout issues on New Tab Page (#3568)
  Import Add To Dock Translations (#3566)
  Release 7.145.0-1 (#3567)
  Remove Old onboarding intro (#3554)
  fix showing current tab in suggestions (#3562)
@samsymons
Update Package.resolved.
7d4f576
@samsymons
Use macOS 15 runner.
ff8b429
@samsymons samsymons requested a review from ayoy November 13, 2024 20:02
ayoy
ayoy approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@samsymons
Merge branch 'main' into dominik/xcode-16
5f0f86f 
# By Daniel Bernal (3) and others
# Via GitHub
* main:
  Remove the `ld_classic` build setting (#3575)
  text zoom improvements (#3509)
  Add support for local overrides for feature flags (#3571)
  pixels for bookmarks > favorites tab (#3572)
  Sync BSK with macos (#3561)
  Add possibility to stop page loading (#3553)
  [DuckPlayer] Overlay Usage Pixels (#3565)
  Update pr.yml
  Update pr.yml

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@samsymons
Update Package.resolved.
d5358c8
@samsymons
Set BSK to 210.0.2
36b1818
@samsymons samsymons merged commit d1c3a62 into main Nov 15, 2024
13 checks passed
@samsymons samsymons deleted the dominik/xcode-16 branch November 15, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayoy ayoy ayoy approved these changes

Assignees

@samsymons samsymons

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samsymons @ayoy @diegoreymendez