Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer base64 encode customMetadata #3438

Closed
wants to merge 1 commit into from

Conversation

quanganhdo
Copy link
Member

@quanganhdo quanganhdo commented Oct 15, 2024

Task/Issue URL: https://app.asana.com/0/1200019156869587/1208553996092093/f
Tech Design URL:
CC:

Description:

customMetadata to be submitted as JSON string, not base64 encoded.

Steps to test this PR:

  1. Go to VPN > Send Feedback > Report a Problem > VPN
  2. Check your console log. It should look like this
Pixel fired m.ppro.feedback.report-issue ["category": "vpn", "source": "vpn", "subcategory": "appCrashesOrFreezes", "customMetadata": "{\"appInfo\":{\"appVersion\":\"7.141.0\",\"isInternalUser\":true,\"lastExtensionVersionRun\":\"Unknown\"},\"deviceInfo\":{\"osVersion\":\"18.1.0\",\"lowPowerModeEnabled\":false},\"networkInfo\":{\"lastPathChange\":\"nil\",\"lastPathChangeDate\":\"unknown\",\"secondsSincePathChange\":\"unknown\",\"currentPath\":\"NWPath(status: satisfied, mainInterfaceType: Optional(Network.NWInterface.InterfaceType.wifi), utunInterfaceCount: 1, ipsecInterfaceCount: 0, dnsInterfaceCount: 0), unidentifiedInterfaceCount: 2), isConstrained: false, isExpensive: false)\"},\"vpnState\":{\"connectedServer\":\"none\",\"connectedServerIP\":\"none\",\"connectionState\":\"disconnected\"},\"privacyProInfo\":{\"hasPrivacyProAccount\":true,\"hasVPNEntitlement\":true},\"vpnSettingsState\":{\"connectOnLoginEnabled\":false,\"selectedServer\":\"automatic\",\"includeAllNetworksEnabled\":false,\"notifyStatusChangesEnabled\":true,\"customDNS\":false,\"excludeLocalNetworksEnabled\":true,\"enforceRoutesEnabled\":false}}", "description": "Test"]

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@quanganhdo
Copy link
Member Author

quanganhdo commented Oct 15, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @quanganhdo and the rest of your teammates on Graphite Graphite

@quanganhdo quanganhdo marked this pull request as ready for review October 15, 2024 20:47
@quanganhdo quanganhdo requested review from a team and dus7 and removed request for a team October 15, 2024 20:47
@@ -93,6 +93,17 @@ struct VPNMetadata: Encodable {

return String(data: encodedMetadata, encoding: .utf8)
}

func toBase64() -> String {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is still used in DefaultVPNFeedbackSender which is used when usesUnifiedFeedbackForm is false. Is it expected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants