No longer base64 encode customMetadata

[quanganhdo]

Task/Issue URL: https://app.asana.com/0/1200019156869587/1208553996092093/f
Tech Design URL:
CC:

Description:

customMetadata to be submitted as JSON string, not base64 encoded.

Steps to test this PR:

1. Set remote config URL to https://www.jsonblob.com/api/1269060462770511872
2. Go to VPN feedback form and Submit a report
3. Check the console log. The pixel should look like this

👾[Standard-Fired] m_mac_ppro_feedback_report-issue ["subcategory": "failsToConnect", "customMetadata": "{\"privacyProInfo\":{\"hasVPNEntitlement\":true,\"hasPrivacyProAccount\":true},\"deviceInfo\":{\"buildFlavor\":\"dmg\",\"osVersion\":\"15.0.1\",\"lowPowerModeEnabled\":false,\"cpuArchitecture\":\"arm64\"},\"vpnSettingsState\":{\"customDNS\":false,\"excludeLocalNetworksEnabled\":true,\"selectedEnvironment\":\"staging\",\"connectOnLoginEnabled\":false,\"includeAllNetworksEnabled\":false,\"notifyStatusChangesEnabled\":true,\"enforceRoutesEnabled\":false,\"showInMenuBarEnabled\":true,\"selectedServer\":\"automatic\"},\"appInfo\":{\"isInApplicationsDirectory\":true,\"appVersion\":\"1.110.0.282\",\"lastAgentVersionRun\":\"1.109.0.277\",\"lastExtensionVersionRun\":\"none\",\"isInternalUser\":true},\"networkInfo\":{\"currentPath\":\"NWPath(status: satisfied, mainInterfaceType: Optional(Network.NWInterface.InterfaceType.wifi), utunInterfaceCount: 1, ipsecInterfaceCount: 0, dnsInterfaceCount: 0), unidentifiedInterfaceCount: 1), isConstrained: false, isExpensive: false)\"},\"vpnState\":{\"lastKnownFailureDescription\":\"none\",\"lastTunnelErrorDescription\":\"Error domain=NSCocoaErrorDomain code=4099\",\"connectedServerIP\":\"none\",\"lastStartErrorDescription\":\"none\",\"connectionState\":\"disconnected\",\"onboardingState\":\"pending-vpn-approval\",\"connectedServer\":\"none\"},\"loginItemState\":{\"vpnMenuIsRunning\":false,\"notificationsAgentState\":\"notRegistered\",\"vpnMenuState\":\"notRegistered\",\"notificationsAgentIsRunning\":false}}", "source": "settings", "description": "Test\nSome\nDescription", "category": "vpn", "pixelSource": "browser-dmg", "appVersion": "1.110.0"]

Definition of Done:

• Does this PR satisfy our Definition of Done?

---

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

[quanganhdo]

• No longer base64 encode customMetadata #3400 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @quanganhdo and the rest of your teammates on Graphite

[dus7]

A similar question as in duckduckgo/iOS#3438 - DefaultVPNFeedbackSender is still using base64. I see the configuration provided sets the unified feedback to enabled, but still - is it expected to have this discrepancy?