Prevent endless rekey and tunnel update cycle #3091
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 17, 2024
samsymons
approved these changes
Jul 23, 2024
samsymons
reviewed
Jul 23, 2024
| "revision" : "9c65477457126ab7ad963a32b7f85ce08e6bd1a7", | ||
| "version" : "6.0.0" | ||
| "revision" : "dc26bfc6e33ad9c79a719b7f21d5ca0564db1859", | ||
| "version" : "6.3.0" |
There was a problem hiding this comment.
Not sure how C-S-S managed to get this out of sync.
quanganhdo
approved these changes
Jul 23, 2024
|
Merging this tomorrow. |
diegoreymendez
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Jul 30, 2024
Task/Issue URL: https://app.asana.com/0/1207603085593419/1207806947583090/f iOS PR: duckduckgo/iOS#3091 macOS PR: duckduckgo/macos-browser#2987 ## Description Prevents the following endless loop of calls `updateTunnel` > `rekey` > `updateTunnel` > `rekey`. This adds noise to our metrics and is unnecessary.
diegoreymendez
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Jul 30, 2024
Task/Issue URL: https://app.asana.com/0/1207603085593419/1207806947583090/f BSK PR: duckduckgo/BrowserServicesKit#897 iOS PR: duckduckgo/iOS#3091 ## Description Prevents the following endless loop of calls `updateTunnel` > `rekey` > `updateTunnel` > `rekey`. This adds noise to our metrics and is unnecessary.
samsymons
added a commit
that referenced
this pull request
Jul 31, 2024
# By Dominik Kapusta (3) and others # Via GitHub * main: New Tab Page Settings (#3140) New Tab Page Settings Storage (#3159) Prevent endless rekey and tunnel update cycle (#3091) tentatively fix content blocking UI test (#3141) Update Autofill UI test to reflect updated app copy (#3158) Duck player support on RMF (#3146) Release 7.131.0-0 (#3157) Update BSK with autofill 12.1.0 (#3155) Report Autofill issues via Passwords screen (#3116) Update GRDB to 2.4.0 (upstream 6.29.0, SQLCipher 4.6.0) (#3153) Update fastlane to 2.222.0 (#3154) [DuckPlayer] 13. Add openInfo message to Overlay (#3151) [DuckPlayer] 12. Ensure DuckPlayer does not leak without the proper config (#3147) [DuckPlayer] 11. Tab views and Pixel updates (#3145) Remove the NETWORK_PROTECTION compilation flag (#3139) Add favorites empty state tooltip (#3119) Bump submodules/privacy-reference-tests from `a603ff9` to `afb4f61` (#3113) iOS 14 deprecation cleanup (#3098) Update Xcode version to 15.4 (#3142) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Aug 1, 2024
# By Dominik Kapusta (3) and others # Via GitHub * main: Automatically add Asana task to iOS App Board (#3168) [DuckPlayer] 14. Potential fix to crash (#3161) New Tab Page Settings (#3140) New Tab Page Settings Storage (#3159) Prevent endless rekey and tunnel update cycle (#3091) tentatively fix content blocking UI test (#3141) Update Autofill UI test to reflect updated app copy (#3158) Duck player support on RMF (#3146) Release 7.131.0-0 (#3157) Update BSK with autofill 12.1.0 (#3155) Report Autofill issues via Passwords screen (#3116) Update GRDB to 2.4.0 (upstream 6.29.0, SQLCipher 4.6.0) (#3153) Update fastlane to 2.222.0 (#3154) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207603085593419/1207806947583090/f
BSK PR: duckduckgo/BrowserServicesKit#897
macOS PR: duckduckgo/macos-browser#2987
Description
Prevents the following endless loop of calls
updateTunnel>rekey>updateTunnel>rekey.This adds noise to our metrics and is unnecessary.
Testing
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation