Prevent endless rekey and tunnel update cycle #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoreymendez
commented
Jul 17, 2024
diegoreymendez
commented
Jul 17, 2024
Sources/NetworkProtection/Diagnostics/NetworkProtectionEntitlementMonitor.swift
Show resolved
Hide resolved
diegoreymendez
commented
Jul 17, 2024
diegoreymendez
commented
Jul 17, 2024
diegoreymendez
commented
Jul 17, 2024
diegoreymendez
commented
Jul 17, 2024
diegoreymendez
commented
Jul 17, 2024
diegoreymendez
commented
Jul 17, 2024
diegoreymendez
commented
Jul 17, 2024
diegoreymendez
commented
Jul 17, 2024
This was referenced Jul 17, 2024
samsymons
reviewed
Jul 23, 2024
| Task { | ||
| do { | ||
| if let delay { | ||
| try await Task<Never, Never>.sleep(interval: delay) |
There was a problem hiding this comment.
Should be able to simplify this down to Task.sleep I believe.
There was a problem hiding this comment.
I'll keep it because of this, but not sure why that's even needed. 🤷
samsymons
reviewed
Jul 23, 2024
Comment on lines
+1507
to
+1509
| #if os(macOS) | ||
| try? self.tokenStore.deleteToken() | ||
| #endif |
There was a problem hiding this comment.
Do we need to check for system extension vs app extension here? I think it should be fine as-is, but checking anyway.
There was a problem hiding this comment.
Well, if access is revoked it should be fine regardless. The only risk I see is if we get false positives as access-revoked, but then the problem would still not be this code, if that makes sense.
samsymons
approved these changes
Jul 23, 2024
quanganhdo
approved these changes
Jul 23, 2024
|
I'll merge this tomorrow, to allow the internal testing week. |
diegoreymendez
added a commit
to duckduckgo/iOS
that referenced
this pull request
Jul 30, 2024
Task/Issue URL: https://app.asana.com/0/1207603085593419/1207806947583090/f BSK PR: duckduckgo/BrowserServicesKit#897 macOS PR: duckduckgo/macos-browser#2987 ## Description Prevents the following endless loop of calls `updateTunnel` > `rekey` > `updateTunnel` > `rekey`. This adds noise to our metrics and is unnecessary.
diegoreymendez
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Jul 30, 2024
Task/Issue URL: https://app.asana.com/0/1207603085593419/1207806947583090/f BSK PR: duckduckgo/BrowserServicesKit#897 iOS PR: duckduckgo/iOS#3091 ## Description Prevents the following endless loop of calls `updateTunnel` > `rekey` > `updateTunnel` > `rekey`. This adds noise to our metrics and is unnecessary.
samsymons
added a commit
that referenced
this pull request
Jul 31, 2024
* main: Prevent endless rekey and tunnel update cycle (#897)
samsymons
added a commit
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207603085593419/1207806947583090/f
iOS PR: duckduckgo/iOS#3091
macOS PR: duckduckgo/macos-browser#2987
Description
Prevents the following endless loop of calls
updateTunnel>rekey>updateTunnel>rekey.This adds noise to our metrics and is unnecessary.
Testing
See platform-specific PRs for testing instructions.
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation