Add survey action and Privacy Pro attributes
#2879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
changed the title
survey action and Privacy Pro attributes
6 tasks
amddg44
reviewed
May 22, 2024
amddg44
reviewed
May 22, 2024
# By Brad Slayter (1) and others # Via GitHub * main: Check entitlements as part of refreshing the Open VPN shortcut (#2873) Release 7.121.0-0 (#2881) Fix top level navigation blocks (#2871) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
amddg44
approved these changes
May 23, 2024
# By Christopher Brind (2) and others # Via GitHub * main: Autofill engagement KPIs for pixel reporting (BSK update) (#2885) keep strong reference to omnibar while we use it and add a ui test (#2884) Bump BSK (#2887) Recently visited sites UI update and rollout (#2838) Update Sync tests (#2837) Subscription refactoring (#2842) Update autoconsent to v10.8.0 (#2874) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/RemoteMessaging.swift
samsymons
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
May 24, 2024
Task/Issue URL: https://app.asana.com/0/1193060753475688/1207234800675206/f iOS PR: duckduckgo/iOS#2879 macOS PR: duckduckgo/macos-browser#2798 What kind of version bump will this require?: Major Description: This PR adds two things to RMF: A new survey action had been added, with configurable parameters New Privacy Pro attributes have been added
samsymons
added a commit
that referenced
this pull request
May 24, 2024
# By Daniel Bernal (2) and others # Via GitHub * main: Privacy Pro Follow ups (#2882) Clean up subscriptionFeature on init (#2880) apply user agent overrides to downloads (#2883) Add `survey` action and Privacy Pro attributes (#2879) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/RemoteMessaging.swift # DuckDuckGoTests/RemoteMessagingStoreTests.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1193060753475688/1207234800675206/f
Tech Design URL:
CC:
Description:
Client PR for duckduckgo/BrowserServicesKit#826
Steps to test this PR:
Device Testing:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template