Add survey action and Privacy Pro attributes
#826
Merged
+290
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* main: Fix top level navigation blocks (#825)
8 tasks
samsymons
commented
May 21, 2024
Sources/RemoteMessaging/Mappers/RemoteMessagingSurveyActionMapping.swift
Show resolved
Hide resolved
samsymons
commented
May 21, 2024
amddg44
reviewed
May 22, 2024
Also, update tests to make sure that a message which cannot be read successfully does not impact subsequent messages.
samsymons
added a commit
to duckduckgo/iOS
that referenced
this pull request
May 24, 2024
Task/Issue URL: https://app.asana.com/0/1193060753475688/1207234800675206/f Tech Design URL: CC: Description: Client PR for duckduckgo/BrowserServicesKit#826 Steps to test this PR: Update the app to use the staging URL from [Do Not Merge] iOS remote message Privacy Pro test remote-messaging-config#58 Check that the message appears under the correct circumstances, e.g. you are signed into a Privacy Pro account Check that the generated URL contains the parameters requested by the survey
samsymons
added a commit
that referenced
this pull request
May 24, 2024
# Via GitHub * main: Add `survey` action and Privacy Pro attributes (#826) # Conflicts: # Sources/RemoteMessaging/Matchers/UserAttributeMatcher.swift # Tests/BrowserServicesKitTests/RemoteMessaging/Mappers/JsonToRemoteConfigModelMapperTests.swift # Tests/BrowserServicesKitTests/RemoteMessaging/Matchers/UserAttributeMatcherTests.swift # Tests/BrowserServicesKitTests/RemoteMessaging/RemoteMessagingConfigMatcherTests.swift # Tests/BrowserServicesKitTests/RemoteMessaging/RemoteMessagingConfigProcessorTests.swift
samsymons
added a commit
that referenced
this pull request
Jun 1, 2024
* main: Replace unowned reference with weak one (#832) Removes VPN waitlist and beta code (#801) Add `survey` action and Privacy Pro attributes (#826) Autofill engagement KPIs for pixel reporting (#830) Bump C-S-S to 5.17.0 (#828) ensure bookmarks can be shown in top hits (#818) Subscription refactoring (#815)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/1193060753475688/1207234800675206/f
iOS PR: duckduckgo/iOS#2879
macOS PR: duckduckgo/macos-browser#2798
What kind of version bump will this require?: Major
Description:
This PR adds two things to RMF:
surveyaction had been added, with configurable parametersSteps to test this PR:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template