Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password screen UI improvements: New open website & show password buttons #2669

Merged
merged 5 commits into from
Apr 8, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Increase icon tappable area
amddg44 committed Apr 4, 2024
commit 033ded998faaec26a387d0926755da713c3c35d0
7 changes: 5 additions & 2 deletions DuckDuckGo/AutofillLoginDetailsView.swift
Original file line number Diff line number Diff line change
@@ -502,6 +502,8 @@ private struct CopyableCell: View {
}
}
.buttonStyle(.plain) // Prevent taps from being forwarded to the container view
// can't use .clear here or else both button padded area and container both respond to tap events
.background(BackgroundColor(isSelected: selectedCell == id).color.opacity(0))
.accessibilityLabel(buttonAccessibilityLabel)
.contentShape(Rectangle())
.frame(width: Constants.textFieldTapSize, height: Constants.textFieldTapSize)
@@ -527,6 +529,7 @@ private struct CopyableCell: View {
}
}
.buttonStyle(.plain) // Prevent taps from being forwarded to the container view
.background(BackgroundColor(isSelected: selectedCell == id).color.opacity(0))
.accessibilityLabel(secondaryButtonAccessibilityLabel)
.contentShape(Rectangle())
.frame(width: Constants.textFieldTapSize, height: Constants.textFieldTapSize)
@@ -634,8 +637,8 @@ private struct Constants {
static let verticalPadding: CGFloat = 4
static let minRowHeight: CGFloat = 60
static let textFieldImageOpacity: CGFloat = 0.84
static let textFieldImageSize: CGFloat = 20
static let textFieldTapSize: CGFloat = 32
static let textFieldImageSize: CGFloat = 24
static let textFieldTapSize: CGFloat = 36
static let insets = EdgeInsets(top: 0, leading: 16, bottom: 0, trailing: 16)
}


Unchanged files with check annotations Beta

// this function is now static and outside of Favicons, otherwise there is a circular dependency between
// Favicons and NotFoundCachingDownloader
public static func defaultResource(forDomain domain: String?, sourcesProvider: FaviconSourcesProvider) -> Kingfisher.ImageResource? {

Check warning on line 27 in Core/FaviconsHelper.swift

GitHub Actions / Unit Tests

'ImageResource' is deprecated: This type conflicts with `GeneratedAssetSymbols.ImageResource` in Swift 5.9. Renamed to avoid issues in the future.

Check warning on line 27 in Core/FaviconsHelper.swift

GitHub Actions / Unit Tests

'ImageResource' is deprecated: This type conflicts with `GeneratedAssetSymbols.ImageResource` in Swift 5.9. Renamed to avoid issues in the future.

Check warning on line 27 in Core/FaviconsHelper.swift

GitHub Actions / Make Release Build

'ImageResource' is deprecated: This type conflicts with `GeneratedAssetSymbols.ImageResource` in Swift 5.9. Renamed to avoid issues in the future.

Check warning on line 27 in Core/FaviconsHelper.swift

GitHub Actions / Make Release Build

'ImageResource' is deprecated: This type conflicts with `GeneratedAssetSymbols.ImageResource` in Swift 5.9. Renamed to avoid issues in the future.
guard let domain = domain,
let source = sourcesProvider.mainSource(forDomain: domain) else { return nil }
let key = Favicons.createHash(ofDomain: domain)
return ImageResource(downloadURL: source, cacheKey: key)

Check warning on line 32 in Core/FaviconsHelper.swift

GitHub Actions / Unit Tests

'ImageResource' is deprecated: This type conflicts with `GeneratedAssetSymbols.ImageResource` in Swift 5.9. Renamed to avoid issues in the future.

Check warning on line 32 in Core/FaviconsHelper.swift

GitHub Actions / Make Release Build

'ImageResource' is deprecated: This type conflicts with `GeneratedAssetSymbols.ImageResource` in Swift 5.9. Renamed to avoid issues in the future.

Check warning on line 32 in Core/FaviconsHelper.swift

GitHub Actions / Make Release Build

'ImageResource' is deprecated: This type conflicts with `GeneratedAssetSymbols.ImageResource` in Swift 5.9. Renamed to avoid issues in the future.
}
}
return image
}
public func defaultResource(forDomain domain: String?) -> Kingfisher.ImageResource? {

Check warning on line 444 in DuckDuckGo/Favicons.swift

GitHub Actions / Unit Tests

'ImageResource' is deprecated: This type conflicts with `GeneratedAssetSymbols.ImageResource` in Swift 5.9. Renamed to avoid issues in the future.

Check warning on line 444 in DuckDuckGo/Favicons.swift

GitHub Actions / Unit Tests

'ImageResource' is deprecated: This type conflicts with `GeneratedAssetSymbols.ImageResource` in Swift 5.9. Renamed to avoid issues in the future.

Check warning on line 444 in DuckDuckGo/Favicons.swift

GitHub Actions / Make Release Build

'ImageResource' is deprecated: This type conflicts with `GeneratedAssetSymbols.ImageResource` in Swift 5.9. Renamed to avoid issues in the future.

Check warning on line 444 in DuckDuckGo/Favicons.swift

GitHub Actions / Make Release Build

'ImageResource' is deprecated: This type conflicts with `GeneratedAssetSymbols.ImageResource` in Swift 5.9. Renamed to avoid issues in the future.
return FaviconsHelper.defaultResource(forDomain: domain, sourcesProvider: sourcesProvider)
}