Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password screen UI improvements: New open website & show password buttons #2669

Merged
merged 5 commits into from
Apr 8, 2024

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented Apr 4, 2024

Task/Issue URL: https://app.asana.com/0/1200930669568058/1206365535975347/f
Tech Design URL:
CC:

Description:
Adds small UI improvements to the Passwords screen including:

  • New website link button to open websites with a single tap (globe icon)
  • New password visibility toggle button to show / hide passwords with a single tap
  • Hidden password character count limit reduced from 40 to 22 so that the hidden version of the password displays as a single line

Steps to test this PR:

  1. Go to Passwords screen and access a saved credential with a saved username, password and website
  2. Tap the eye icon button next to the password and confirm the password is unmasked and the eye icon updates to one with a line through it
  3. Tap the updated eye icon button again and confirm the password is masked again
  4. Tap the copy button and confirm it still copies the password to clipboard
  5. Tap the password row and confirm the menu options to "Show Password" and "Copy Password" still present as before
  6. Modify the saved password to be so long that its text will wrap when done editing.
  7. Confirm that the masked password displays as a single line and doesn't wrap, but does wrap to multi-line when unmasked
  8. Tap the globe icon next to the website and confirm that you are taken to a new tab and that that website loads (note: website must be a valid url for this to trigger)
  9. Tap the website row and confirm the menu options to "Copy Website URL" and "Open Website" still present as before

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@amddg44 amddg44 changed the title Anya/passwords clickable website icon Password screen UI improvements: New open website & show password buttons Apr 4, 2024
@amddg44 amddg44 requested a review from aataraxiaa April 4, 2024 08:39
Copy link
Contributor

@aataraxiaa aataraxiaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks great 👍🏼

@amddg44 amddg44 merged commit 27f288e into main Apr 8, 2024
14 checks passed
@amddg44 amddg44 deleted the anya/passwords-clickable-website-icon branch April 8, 2024 10:21
samsymons added a commit that referenced this pull request Apr 8, 2024
…flagger

# By Daniel Bernal (2) and others
# Via Federico Cappelli (1) and others
* main:
  Release 7.114.1-0 (#2700)
  Refresh token on Appear (#2699)
  Do not signout user on API failure (#2698)
  Release 7.115.0-0 (#2693)
  Password screen UI improvements: New open website & show password buttons (#2669)
  Removed VPN waitlist beta pixels (#2686)
  VPN: Cleanup authorize call (#2685)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants