Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving the toggle to the top of the dashboard #2166

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Conversation

shakyShane
Copy link
Collaborator

@shakyShane shakyShane commented Nov 15, 2023

Task/Issue URL: https://app.asana.com/0/0/1205883650709869/f
Tech Design URL:
CC:

Description:

  • Updates privacy-dashboard to 3.0.0
  • Moved the toggle to the top of the primary screen

Steps to test this PR:

  1. No functionality changed
  2. Just the toggle + breakage form link is moved to the top

Dashboard PR.jpg

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@shakyShane
Copy link
Collaborator Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@shakyShane
Copy link
Collaborator Author

Closing in favour of #2168

@shakyShane shakyShane closed this Nov 17, 2023
@shakyShane shakyShane reopened this Nov 30, 2023
@federicocappelli federicocappelli self-requested a review November 30, 2023 12:03
Copy link
Member

@federicocappelli federicocappelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shakyShane shakyShane merged commit 3b04091 into develop Nov 30, 2023
10 checks passed
@shakyShane shakyShane deleted the shane/port-toggle branch November 30, 2023 12:30
samsymons added a commit that referenced this pull request Nov 30, 2023
# By Dominik Kapusta (1) and others
# Via GitHub
* develop:
  moving the toggle to the top of the dashboard (#2166)
  Allow automated fetching of synced bookmarks' favicons (#2163)
  NetP Geoswitching Design Review feedback (#2206)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons added a commit that referenced this pull request Dec 5, 2023
* develop: (40 commits)
  Address Bar Spoofing Tests + Remediation (#2181)
  Update Sync e2e tests to fit the new UI (#2215)
  NetP waitlist final touches (#2209)
  NetP: Remove port from server address (#2214)
  NetP: Fix list row colours (#2213)
  Reset VPN waitlist T&C (#2212)
  Report macOS active/new user for netP (#2207)
  Sabrina/sync setup update (#2198)
  new pixels for toolbars and share sheet  (#2208)
  Use design system fonts throughout NetP (#2211)
  moving the toggle to the top of the dashboard (#2166)
  Allow automated fetching of synced bookmarks' favicons (#2163)
  NetP Geoswitching Design Review feedback (#2206)
  update theme to use system colours (#2180)
  Release 7.99.0 (#2205)
  Update iOS privacy defaults (#2185)
  Remove disabled switches from VPN Settings screen (#2203)
  Update BSK for VPN settings (#2165)
  Fix migrating from Bookmarks V2 and older (#2196)
  Autofill pixel parameter removed (#2182)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants