Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade privacy-dashboard to 3.0.0 #549

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Upgrade privacy-dashboard to 3.0.0 #549

merged 1 commit into from
Nov 30, 2023

Conversation

shakyShane
Copy link
Collaborator

@shakyShane shakyShane commented Nov 6, 2023 •
edited
Loading

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/0/1205883650709864/f
iOS PR: duckduckgo/iOS#2166
macOS PR: duckduckgo/macos-browser#1809
What kind of version bump will this require?: Major/Minor/Patch

Optional:

Tech Design URL:
CC:

Description:

Please see the macOS PR for details

Steps to test this PR:
1.
1.

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • macOS 10.15
  • macOS 11
  • macOS 12
Internal references:

Software Engineering Expectations
Technical Design Template

@shakyShane
Copy link
Collaborator Author

shakyShane commented Nov 6, 2023 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@shakyShane shakyShane force-pushed the shane/port-toggle branch 2 times, most recently from 13da4ba to dc1467e Compare November 7, 2023 22:32
@shakyShane shakyShane force-pushed the shane/port-toggle branch 2 times, most recently from 4e67c36 to d256816 Compare November 15, 2023 19:06
@shakyShane shakyShane marked this pull request as ready for review November 15, 2023 19:44
@shakyShane shakyShane changed the title shane/port-toggle Upgrade privacy-dashboard to 3.0.0 Nov 15, 2023
@shakyShane
Copy link
Collaborator Author

Closing in favour of #566

@shakyShane shakyShane closed this Nov 17, 2023
@shakyShane shakyShane reopened this Nov 30, 2023
@federicocappelli federicocappelli self-requested a review November 30, 2023 12:00
federicocappelli
federicocappelli approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@federicocappelli federicocappelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @shakyShane

@shakyShane shakyShane merged commit fe6b009 into main Nov 30, 2023
5 checks passed
@shakyShane shakyShane deleted the shane/port-toggle branch November 30, 2023 12:11
samsymons added a commit that referenced this pull request Nov 30, 2023
@samsymons
Merge branch 'main' into sam/netp-waitlist-final-touches
b24d4b9 
* main:
  bump privacy-dashboard to 3.0.0 (#549)
  Allow automated fetching of synced bookmarks' favicons (#564)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@federicocappelli federicocappelli federicocappelli approved these changes

Assignees

@shakyShane shakyShane

@miasma13 miasma13

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shakyShane @federicocappelli @miasma13