Fixes an issue that crashes the NetP extension #2156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tom Strba <[email protected]> Co-authored-by: David Harbage <[email protected]> Co-authored-by: Dax Mobile <[email protected]> Co-authored-by: GioSensation <[email protected]>
Task/Issue URL: https://app.asana.com/0/0/1205738275545703/f BSK PR: duckduckgo/BrowserServicesKit#536 macOS PR: duckduckgo/macos-browser#1690 ## Description Integrates the latest changes from BSK.
Co-authored-by: Shane Osbourne <[email protected]>
Task/Issue URL: https://app.asana.com/0/414235014887631/1205784963805147/f Tech Design URL: CC: @graeme @diegoreymendez Description: This PR adds an iOS VPN quick action.
Task/Issue URL: https://app.asana.com/0/1205747234047385/1205747234047385 Autofill Release: https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/9.0.0 BSK PR: duckduckgo/BrowserServicesKit#537 Description Updates Autofill to version 9.0.0.
Task/Issue URL: https://app.asana.com/0/0/1205755216985387/f BSK PR: duckduckgo/BrowserServicesKit#532 macOS PR: duckduckgo/macos-browser#1751 ## Description Integrates the latest BSK changes.
Task/Issue URL: https://app.asana.com/0/414709148257752/1205793869765618/f Tech Design URL: CC: Description: When launching the app from deeplink the webView size can be 0,0 causing UIGraphicsBeginImageContextWithOptions to crash
Co-authored-by: Sam Symons <[email protected]>
Task/Issue URL: https://app.asana.com/0/414709148257752/1205648554243412/f Tech Design URL: CC: Description: Update the RMF production URL to be the correct production URL
Co-authored-by: Shane Osbourne <[email protected]>
Task/Issue URL: https://app.asana.com/0/414235014887631/1205843304285892/f Description: Update bookmarks sync response handler to actually process favorites also when an empty folder is received from the server.
Task/Issue URL: https://app.asana.com/0/414709148257752/1205885847854331/f Tech Design URL: CC: Description: Fix bug that shows black bar when launching a favorite with the keyboard open.
Task/Issue URL: https://app.asana.com/0/414709148257752/1205886244765299/f Tech Design URL: CC: Description: Fix bug preventing keyboard shortcuts working correctly.
Task/Issue URL: https://app.asana.com/0/1199333091098016/1205714053673490/f Tech Design URL: CC: Description: This PR disables AppTP database initialization when the feature is disabled.
Task/Issue URL: https://app.asana.com/0/1205237866452338/1205902260676401/f Tech Design URL: CC: Description: Update URL in tests to reflect latest blocking rules.
Task/Issue URL: https://app.asana.com/0/0/1205909514194474/f Tech Design URL: CC: Description: This PR updates BSK to account for a NetP change.
Task/Issue URL: https://app.asana.com/0/0/1205915133582459/f Description: Update BSK, no changes in iOS code,
Co-authored-by: Shane Osbourne <[email protected]>
Task/Issue URL: https://app.asana.com/0/1201493110486074/1204926049616866/f Tech Design URL: https://app.asana.com/0/481882893211075/1205418608802079/f Description: This change introduces form factor specific favorites to be used when Sync is enabled. 1 favorites folder is replaced by 3 folders – mobile, desktop and unified. Users always see only 1 folder and it's their form-factor-specific one. Only users with Sync enabled get to choose whether they want to see the form-factor-specific favorites or unified (desktop + mobile) favorites. The setting itself is synced between devices in the Sync account. BookmarkEntity's isFavorite is replaced with isFavorite(on:) taking folder as a parameter. API for adding to favorites and removing from favorites was updated to take multiple favorites folders as needed. FavoritesDisplayMode enum is introduced to manage display mode in clients. Bookmarks and Favorites related view models used on iOS are updated to take favorites display mode and reload their data as the mode changes. In SyncDataProviders, an abstract SettingSyncHandler class was added to support adding an arbitrary setting (key-value pair) to Sync. It's subclassed by EmailProtectionSyncHandler and FavoritesDisplayModeSyncHandlerBase (that needs to be subclassed in client apps due to differences in User Defaults storage between iOS and macOS apps).
Task/Issue URL: https://app.asana.com/0/414235014887631/1205930555428985/f Tech Design URL: CC: @ayoy Description: This PR adds DesignResourcesKit as a dependency of SyncUI. SyncUI already imports it in a number of places, but doesn't have it declared as a dependency.
…play mode (#2148) Task/Issue URL: https://app.asana.com/0/1201493110486074/1205918060547867/f Description: Listen to changes to favorites display mode also in HomeViewController and reload favorites view as needed.
…2135) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Graeme Arthur <[email protected]>
This was referenced Nov 14, 2023
|
Will reopen when merging the BSK changes to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: this PR is targetting
release/7.94.0Task/Issue URL: https://app.asana.com/0/0/1205948647103120/f
BSK PR: duckduckgo/BrowserServicesKit#561
macOS PR: duckduckgo/macos-browser#1846
Description
Fixes a crasher in NetP iOS and macOS.
Testing
There's not a lot to test, it seems I merged a test line by mistake to BSK.
Internal references:
Software Engineering Expectations
Technical Design Template