Removing an exception that was merged by mistake #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoreymendez
changed the title
diegoreymendez
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Nov 15, 2023
Task/Issue URL: https://app.asana.com/0/0/1205948641232666/f BSK PR: duckduckgo/BrowserServicesKit#561 iOS PR: iOS will be integrated against the latest BSK, in a follow up PR. ## Description Fixes a crasher in NetP iOS and macOS.
This was referenced Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205948647103119/f
iOS PR: iOS will be integrated against the latest BSK, in a follow up PR.
macOS PR: duckduckgo/macos-browser#1849
What kind of version bump will this require?: Patch
Description
Removes some code that was merged by mistake.
Testing
Since we're removing code that was apparently added by mistake, ensure the VPN works fine, and otherwise make sure the removal makes sense.
Internal references:
Software Engineering Expectations
Technical Design Template