Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support environment setting #2140

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Support environment setting #2140

merged 1 commit into from
Nov 9, 2023

Conversation

quanganhdo
Copy link
Member

Task/Issue URL: https://app.asana.com/0/1199230911884351/1204544375475063/f

Description:

This PR points BSK package to the corresponding commit.

Internal references:

Software Engineering Expectations
Technical Design Template

@quanganhdo quanganhdo self-assigned this Nov 9, 2023
@quanganhdo quanganhdo changed the title Update tracked BSK commit Support environment setting Nov 9, 2023
@quanganhdo quanganhdo force-pushed the anh/select-environment branch from d0e2296 to 4025f84 Compare November 9, 2023 16:46
Copy link
Contributor

@diegoreymendez diegoreymendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good.

@quanganhdo quanganhdo force-pushed the anh/select-environment branch from 4025f84 to 1694331 Compare November 9, 2023 17:52
@quanganhdo quanganhdo force-pushed the anh/select-environment branch from 1694331 to 3f23912 Compare November 9, 2023 18:36
@quanganhdo quanganhdo merged commit f4c0eba into develop Nov 9, 2023
9 checks passed
@quanganhdo quanganhdo deleted the anh/select-environment branch November 9, 2023 18:51
samsymons added a commit that referenced this pull request Nov 9, 2023
# By Christopher Brind (3) and others
# Via GitHub (1) and Michal Smaga (1)
* develop:
  Support environment setting (#2140)
  Update BSK (#2136)
  Update BSK for NetP change (#2134)
  Update test to match exact tracker (#2133)
  Avoid AppTP DB initialization when disabled (#2090)
  re-enable keyboard shortcuts (#2132)
  fix favorite launch with keyboard bug (#2131)
  Fix syncing empty favorites folders (#2121)
  kill variant when receiving atb update (#2130)
  Adding 'protectionsState' to breakage form submission (#2120)
  Release 7.96.0 (#2128)
  Update remote messaging production url (#2124)
  Alert user about abnormal app conditions (#2110)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons added a commit that referenced this pull request Nov 10, 2023
* develop:
  Support environment setting (#2140)
  Update BSK (#2136)
  Update BSK for NetP change (#2134)
  Update test to match exact tracker (#2133)
  Avoid AppTP DB initialization when disabled (#2090)
  re-enable keyboard shortcuts (#2132)
  fix favorite launch with keyboard bug (#2131)
  Fix syncing empty favorites folders (#2121)
  kill variant when receiving atb update (#2130)
  Adding 'protectionsState' to breakage form submission (#2120)
  Release 7.96.0 (#2128)
  Update remote messaging production url (#2124)
  Alert user about abnormal app conditions (#2110)
  Add e2e test for email protection deep-links (#2123)
  Update to config v4 (#2114)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants