Skip to content

Fine tune unit tests to improve reliability #9289

Fine tune unit tests to improve reliability

Fine tune unit tests to improve reliability #9289

Triggered via pull request November 21, 2024 15:58
Status Failure
Total duration 10m 44s
Artifacts 1

pr.yml

on: pull_request
Create Asana Task
0s
Create Asana Task
Close Asana Task
0s
Close Asana Task
Fit to window
Zoom out
Zoom in

Annotations

5 errors, 26 warnings, and 10 notices
Unit Tests: UnitTests/SubscriptionPagesUseSubscriptionFeatureTests.swift#L185
Unexpectedly found nil while implicitly unwrapping an Optional value
Unit Tests: UnitTests/SubscriptionPagesUseSubscriptionFeatureTests.swift#L185
Unexpectedly found nil while implicitly unwrapping an Optional value
Unit Tests: UnitTests/SubscriptionPagesUseSubscriptionFeatureTests.swift#L185
Unexpectedly found nil while implicitly unwrapping an Optional value
Unit Tests: UnitTests/SubscriptionPagesUseSubscriptionFeatureTests.swift#L185
Unexpectedly found nil while implicitly unwrapping an Optional value
Unit Tests
Process completed with exit code 65.
ShellCheck
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
SwiftLint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Make Release Build
The following actions use a deprecated Node.js version and will be forced to run on node20: webfactory/[email protected], actions/checkout@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Make Release Build: DerivedData/Build/Products/Release-iphonesimulator/PackageFrameworks/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Make Release Build: Core/Pixel.swift#L269
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Make Release Build: Core/StatisticsLoader.swift#L69
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Make Release Build: Core/StatisticsLoader.swift#L91
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Make Release Build: Core/StatisticsLoader.swift#L121
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Make Release Build: Core/StatisticsLoader.swift#L150
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Make Release Build: Core/SyncBookmarksAdapter.swift#L199
'taskID' mutated after capture by sendable closure
Make Release Build: DerivedData/Build/Products/Release-iphonesimulator/PackageFrameworks/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Make Release Build: Core/Pixel.swift#L269
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Make Release Build: Core/StatisticsLoader.swift#L69
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Make Release Build
xcbeautify 2.15.0 is already installed and up-to-date. To reinstall 2.15.0, run: brew reinstall xcbeautify
Unit Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Unit Tests
xcbeautify 2.15.0 is already installed and up-to-date. To reinstall 2.15.0, run: brew reinstall xcbeautify
Unit Tests: DerivedData/Build/Products/Debug-iphonesimulator/PackageFrameworks/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Unit Tests: Core/Pixel.swift#L269
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Unit Tests: Core/StatisticsLoader.swift#L69
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Unit Tests: Core/StatisticsLoader.swift#L91
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Unit Tests: Core/StatisticsLoader.swift#L121
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Unit Tests: Core/StatisticsLoader.swift#L150
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Unit Tests: Core/SyncBookmarksAdapter.swift#L199
'taskID' mutated after capture by sendable closure
Unit Tests
Accent color ‘AccentColor’ is not present in any asset catalogs.
Unit Tests
Background color ‘WidgetBackground’ is not present in any asset catalogs.
Unit Tests: DuckDuckGo/FavoritesDisplayMode+UserDefaults.swift#L23
extension declares a conformance of imported type 'FavoritesDisplayMode' to imported protocol 'LosslessStringConvertible'; this will not behave correctly if the owners of 'Bookmarks' introduce this conformance in the future
Unit Tests
Skipped UnitTests.AutofillLoginListViewModelTests.testWhenBreakageReporterConfigEnabledAndReportAlreadyRecentlySavedThenShowBreakageReporterIsFalse
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenCallActionOnOnboardingFinalDialog_ThenDidTapDismissContextualOnboardingActionOnDelegateIsCalled
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewFire_ThenReturnViewOnboardingFireDialog
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewForAfterSearchSpec_AndActionIsTapped_AndTrackersDialogHasNotShown_ThenDidTapDismissContextualOnboardingActionIsCalledOnDelegate
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewForAfterSearchSpec_AndActionIsTapped_AndTrackersDialogHasShown_ThenDidTapDismissContextualOnboardingActionIsCalledOnDelegate
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewForFinalSpec_ThenReturnViewOnboardingFinalDialog
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewForTrackerSpec_AndFireDialogHasNotShown_ThenActionCallsDidAcknowledgeContextualOnboardingTrackersDialog
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewForTrackerSpec_AndFireDialogHasShown_ThenActionCallsDidTapDismissContextualOnboardingAction
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewForTrackerSpec_ThenReturnViewOnboardingTrackersDoneDialog
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewForVisitWebsiteSpec_AndActionIsTapped_AndTrackersDialogHasShown_ThenNavigateToActionIsCalledOnDelegate

Artifacts

Produced during runtime
Name Size
BuildLogs Expired
71.5 MB