Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine tune unit tests to improve reliability #3577

Merged
merged 18 commits into from
Nov 26, 2024
Merged

Conversation

bwaresiak
Copy link
Collaborator

@bwaresiak bwaresiak commented Nov 14, 2024

Task/Issue URL: https://app.asana.com/0/856498667320406/1208724390819804/f
Tech Design URL:
CC:

Description:

  • Separate out WebView/WebKit tests to a new target.
  • Add long-living WebView to host app view hierarchy.
  • Disable flaky tests.
  • Tweak how we wait for expectations when structured concurrency is involved.

Steps to test this PR:

Run tests :)

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link

github-actions bot commented Nov 20, 2024

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against 5faa2c8

@bwaresiak bwaresiak changed the title Fine tune unit tests to include WebView when running Fine tune unit tests to improve reliability Nov 20, 2024
@bwaresiak bwaresiak force-pushed the bartek/tune-unit-tests branch from 39def09 to ca309ea Compare November 21, 2024 11:11
@bwaresiak bwaresiak force-pushed the bartek/tune-unit-tests branch from ca309ea to 605e423 Compare November 21, 2024 11:40
@bwaresiak bwaresiak force-pushed the bartek/tune-unit-tests branch from d980060 to 949ca57 Compare November 21, 2024 15:58
@bwaresiak bwaresiak force-pushed the bartek/tune-unit-tests branch 2 times, most recently from bee6603 to 7d8372b Compare November 21, 2024 23:17
@bwaresiak bwaresiak requested a review from samsymons November 25, 2024 14:41
Copy link
Contributor

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added one note about the warmupWebView logic since it causes a consistent failure for me locally (but not on CI?), otherwise just some small cosmetic comments. Nice work!

@samsymons
Copy link
Contributor

New changes look good, thanks @bwaresiak! I re-ran the workflows a few times and everything was green every time, great work!

@samsymons samsymons merged commit 9b5ad36 into main Nov 26, 2024
13 checks passed
@samsymons samsymons deleted the bartek/tune-unit-tests branch November 26, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants