-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fine tune unit tests to improve reliability #3577
Conversation
39def09
to
ca309ea
Compare
ca309ea
to
605e423
Compare
d980060
to
949ca57
Compare
bee6603
to
7d8372b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, added one note about the warmupWebView
logic since it causes a consistent failure for me locally (but not on CI?), otherwise just some small cosmetic comments. Nice work!
New changes look good, thanks @bwaresiak! I re-ran the workflows a few times and everything was green every time, great work! |
Task/Issue URL: https://app.asana.com/0/856498667320406/1208724390819804/f
Tech Design URL:
CC:
Description:
Steps to test this PR:
Run tests :)
Definition of Done (Internal Only):
Copy Testing:
’
rather than'
Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template