Remove validator app #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has never been used by anyone meaningfully and adds complexity to the dependency tree, so it can be removed.
samsymons
requested review from
bwaresiak,
brindy and
THISISDINOSAUR
as code owners
6 tasks
ayoy
approved these changes
Apr 17, 2024
samsymons
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Apr 17, 2024
Required: Task/Issue URL: https://app.asana.com/0/1200194497630846/1206998874029387/f iOS PR: duckduckgo/iOS#2754 macOS PR: duckduckgo/macos-browser#2643 What kind of version bump will this require?: Major Description: This PR updates BSK to account for the changes in duckduckgo/TrackerRadarKit#20.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1200194497630846/1206998874029387/f
Tech Design URL:
CC:
Description:
This PR removes the validator app, which has never really been used by anyone and is adding complexity to the dependency tree.
BSK: duckduckgo/BrowserServicesKit#784
Steps to test this PR:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template