Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove validator app #784

Merged
merged 3 commits into from
Apr 17, 2024
Merged

Remove validator app #784

merged 3 commits into from
Apr 17, 2024

Conversation

samsymons
Copy link
Contributor

@samsymons samsymons commented Apr 16, 2024

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/1200194497630846/1206998874029387/f
iOS PR: duckduckgo/iOS#2754
macOS PR: duckduckgo/macos-browser#2643
What kind of version bump will this require?: Major

Description:

This PR updates BSK to account for the changes in duckduckgo/TrackerRadarKit#20.

Steps to test this PR:

  1. See client PRs

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • macOS 10.15
  • macOS 11
  • macOS 12

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

* main:
  Keep a weak reference to UserScriptMessageBroker (#783)
@samsymons samsymons merged commit 5821f70 into main Apr 17, 2024
7 checks passed
@samsymons samsymons deleted the sam/remove-validator branch April 17, 2024 15:13
samsymons added a commit to duckduckgo/iOS that referenced this pull request Apr 17, 2024
samsymons added a commit to duckduckgo/macos-browser that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants