Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix same-document navigation breaking current main frame navigation #873

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Fix same-document navigation breaking current main frame navigation #873

merged 2 commits into from
Jul 1, 2024

Conversation

mallexxx
Copy link
Collaborator

@mallexxx mallexxx commented Jul 1, 2024 •
edited
Loading

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/1202406491309510/1207272003030126/f
iOS PR: not affected
macOS PR:
What kind of version bump will this require?: Patch

Description:

  • Fixes same-document navigation breaking actual main frame navigation causing assertion

Steps to test this PR:

  1. Use fire to burn active sessions
  2. Open https://github.com/duckduckgo/macos-browser, log in with 2-factor auth
  3. Validate no assertion failure raised
Internal references:

Software Engineering Expectations
Technical Design Template

@mallexxx mallexxx requested a review from ayoy July 1, 2024 07:44
@mallexxx mallexxx mentioned this pull request Jul 1, 2024
Merged
1 task
ayoy
ayoy approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please make sure you fix a failing test before merging. Thanks @mallexxx!

@mallexxx mallexxx merged commit ae719ad into main Jul 1, 2024
7 checks passed
@mallexxx mallexxx deleted the alex/fix-same-doc-breaking-current-nav branch July 1, 2024 08:53
mallexxx added a commit to duckduckgo/macos-browser that referenced this pull request Jul 1, 2024
@mallexxx
Fix same-document navigation breaking current main frame navigation (#…
5fccf8e 
…2927)

Task/Issue URL: https://app.asana.com/0/1202406491309510/1207272003030126/f
BSK PR: duckduckgo/BrowserServicesKit#873
samsymons added a commit that referenced this pull request Jul 4, 2024
@samsymons
Merge branch 'main' into sam/vpn-snooze-initial-support
dab08b1 
* main:
  Tentatively fixes connectivity and tunnel start issues (#875)
  Tentatively fixes connectivity and tunnel start issues (#875)
  update reference to C-S-S (#871)
  Autoplay settings (#872)
  Fix same-document navigation breaking current main frame navigation (#873)
  Remove Privacy Pro from device once expired account is deleted (#870)
  Make entitlements var public (#867)
  Toggle reports limiter (#868)
  Silence tunnel startup noise with no access token available (#863)
  Fixes an issue when uninstalling the VPN over UDS, where the menu app wouldn't quit (#866)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayoy ayoy ayoy approved these changes

Assignees

@mallexxx mallexxx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mallexxx @ayoy