Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix same-document navigation breaking current main frame navigation #2927

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

mallexxx
Copy link
Collaborator

@mallexxx mallexxx commented Jul 1, 2024

Task/Issue URL: https://app.asana.com/0/1202406491309510/1207272003030126/f
BSK PR: duckduckgo/BrowserServicesKit#873

Description:

  • Fixes same-document navigation breaking actual main frame navigation causing assertion

Steps to test this PR:

  1. Use fire to burn active sessions
  2. Open https://github.com/duckduckgo/macos-browser, log in with 2-factor auth
  3. Validate no assertion failure raised

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@mallexxx mallexxx requested a review from ayoy July 1, 2024 07:47
@mallexxx mallexxx changed the title set BSK rev Fix same-document navigation breaking current main frame navigation Jul 1, 2024
Copy link
Collaborator

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mallexxx mallexxx merged commit 5fccf8e into main Jul 1, 2024
20 checks passed
@mallexxx mallexxx deleted the alex/fix-same-doc-breaking-current-nav branch July 1, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants