-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
experiment default metrics pixels #1107
Merged
Merged
Changes from 1 commit
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
216a00e
implement experiment manager
SabrinaTardio d8b385c
Merge branch 'main' into sabrina/add-experiment-manager
SabrinaTardio 914a5ed
fix lint issues
SabrinaTardio 93247a3
fix linting issue
SabrinaTardio 5d530f2
wrap UserDefaults
SabrinaTardio 2dcef1e
fix linting
SabrinaTardio 5aec88d
refactor
SabrinaTardio b188d67
fix linting
SabrinaTardio 1054923
address some comments
SabrinaTardio c05aa96
minor refactor
SabrinaTardio 8387472
use Constants enum
SabrinaTardio e862ad8
add Targets and configurations
SabrinaTardio 6090a15
fix linting issues
SabrinaTardio 14f92e9
initial implementation
SabrinaTardio 8bda08c
add tests
SabrinaTardio 9a19db2
Merge branch 'main' into sabrina/add-experiment-logic
SabrinaTardio 56c54a7
refactor
SabrinaTardio 86b7c97
getAllActiveExperiments tests
SabrinaTardio 2595fcf
sort linting issues
SabrinaTardio 86d6f7b
fix linting
SabrinaTardio 95c4470
don't break the API
SabrinaTardio c30f0b4
Merge branch 'main' into sabrina/add-experiment-logic
SabrinaTardio 727e813
implement PixelExperimentKit
SabrinaTardio 69dc2fd
implement framework
SabrinaTardio cfe3b13
clean up
SabrinaTardio 1e426e2
Merge branch 'main' into sabrina/experiment-framework
SabrinaTardio 26fa2ed
fix linting
SabrinaTardio ee2f891
have only one interface method
SabrinaTardio b3224fe
fix lint
SabrinaTardio b057431
address comments
SabrinaTardio e92cbb5
Merge branch 'sabrina/experiment-framework' into sabrina/experiment-p…
SabrinaTardio 4756b60
update after merge
SabrinaTardio 4f2d28b
Merge branch 'main' into sabrina/experiment-pixels
SabrinaTardio d202980
cleanup
SabrinaTardio bfb7a5e
fix lint errors
SabrinaTardio a98e9c4
add pixel unique parameter test
SabrinaTardio 7747bdc
remove unwanted code
SabrinaTardio 92bb24f
refactor
SabrinaTardio e7801f9
refactor and add more tests
SabrinaTardio fc1c31e
add tests
SabrinaTardio f03d0e3
Merge branch 'main' into sabrina/experiment-pixels
SabrinaTardio f24740a
fix linting
SabrinaTardio aef82dd
linting
SabrinaTardio 9b65cc7
linting
SabrinaTardio 4992efe
implement firing enrolment pixel
SabrinaTardio 4412bd4
Merge branch 'main' into sabrina/experiment-pixels
SabrinaTardio b202b44
fix tests
SabrinaTardio c62fac4
generalise headers and prefix name
SabrinaTardio cc6c1b6
address comments
SabrinaTardio b567a22
add isDry for new unique params
SabrinaTardio 2b0f434
fix linting
SabrinaTardio 15eed7b
fix tests
SabrinaTardio e0e45ca
fix iOS pixel naming
SabrinaTardio cd6d89a
address comments and remove m_ from experiments
SabrinaTardio 9568123
remove unwanted change
SabrinaTardio 8db91da
fix mac pixel names
SabrinaTardio 8c2a9c6
fix test
SabrinaTardio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
won't it have some side effect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically so far is always macOS and we have some NetP etc sources that still want macOS header, so basically all I am doing here is making sure that is it comes from iOS (that for now it is only used for the experiment) it has the iOS/ipadOS header… avoiding changes for anything else that is using it currently.
When we do the full migration we will need to adjust it but we need to consider other Sources as well