Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experiment default metrics pixels #1107

Merged
merged 57 commits into from
Dec 5, 2024
Merged

Conversation

SabrinaTardio
Copy link
Contributor

@SabrinaTardio SabrinaTardio commented Nov 29, 2024

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/1204186595873227/1208775176602791/f
iOS PR: in prep
macOS PR: duckduckgo/macos-browser#3622
What kind of version bump will this require?: Major

Optional:

Tech Design URL: https://app.asana.com/0/1204186595873227/1208682592686299
CC: @bwaresiak

Description: Implements PixelExperimentKit to provide Experiment metrics API to clients

Steps to test this PR:

  1. Check tests pass

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • macOS 10.15
  • macOS 11
  • macOS 12

Internal references:

Software Engineering Expectations
Technical Design Template

@SabrinaTardio SabrinaTardio changed the title Sabrina/experiment pixels experiment pixels Dec 2, 2024
@SabrinaTardio SabrinaTardio marked this pull request as ready for review December 2, 2024 11:07
@SabrinaTardio SabrinaTardio changed the title experiment pixels experiment default metrics pixels Dec 2, 2024
Sources/PixelKit/Extensions/Disctionary+PixelKit.swift Outdated Show resolved Hide resolved
Sources/PixelKit/Extensions/Disctionary+PixelKit.swift Outdated Show resolved Hide resolved
Sources/PixelKit/PixelKit.swift Show resolved Hide resolved
Sources/PixelExperimentKit/PixelExperimentKit.swift Outdated Show resolved Hide resolved
Sources/PixelExperimentKit/PixelExperimentKit.swift Outdated Show resolved Hide resolved
Sources/PixelExperimentKit/PixelExperimentKit.swift Outdated Show resolved Hide resolved
Sources/PixelExperimentKit/PixelExperimentKit.swift Outdated Show resolved Hide resolved
Copy link
Contributor

@jaceklyp jaceklyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small things, otherwise looking good :)

Sources/PixelExperimentKit/ExperimentEventTracker.swift Outdated Show resolved Hide resolved
Sources/PixelExperimentKit/ExperimentEventTracker.swift Outdated Show resolved Hide resolved
Sources/PixelExperimentKit/PixelExperimentKit.swift Outdated Show resolved Hide resolved
Sources/PixelExperimentKit/PixelExperimentKit.swift Outdated Show resolved Hide resolved
Sources/PixelKit/PixelKit.swift Outdated Show resolved Hide resolved
@@ -204,7 +205,7 @@ public final class PixelKit {
case Source.macDMG.rawValue, Source.macStore.rawValue:
headers[Header.client] = "macOS"
default:
break
headers[Header.client] = "macOS"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't it have some side effect?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically so far is always macOS and we have some NetP etc sources that still want macOS header, so basically all I am doing here is making sure that is it comes from iOS (that for now it is only used for the experiment) it has the iOS/ipadOS header… avoiding changes for anything else that is using it currently.
When we do the full migration we will need to adjust it but we need to consider other Sources as well

@SabrinaTardio SabrinaTardio merged commit e5d390c into main Dec 5, 2024
7 checks passed
@SabrinaTardio SabrinaTardio deleted the sabrina/experiment-pixels branch December 5, 2024 12:47
samsymons added a commit that referenced this pull request Dec 19, 2024
* main: (24 commits)
  change api (#1133)
  Ensure authToken is present before calling refreshAuthTokenIfNeeded
  Add 'locale' to report broken site params
  Add 'locale' to report broken site params
  Ensure authToken is present before calling refreshAuthTokenIfNeeded
  Privacy Pro Free Trials - Models and API (#1120)
  remove MaliciousSiteProtectionSubfeature (#1131)
  Malware protection 6: Malware integration (#1099)
  Add underlying error to PrivacyStatsError (#1130)
  Initial changes for compilation time tracking. (#1111)
  iOS System level credential provider (#1127)
  Increase ratio of complete form saves (#1124)
  Add PrivacyStatsError.failedToClearPrivacyStats (#1128)
  Update autofill to 16.0.0 (#1122)
  Update local network routing (#1117)
  Update RMF version matching to ignore build number (#1118)
  Fix threading issue between using a Semaphore and async/await (#1115)
  add experiment test fake feature (#1119)
  Bump Tests/BrowserServicesKitTests/Resources/privacy-reference-tests from `a603ff9` to `6133e7d` (#1109)
  experiment default metrics pixels (#1107)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants