Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for ListControlUnboundActionList #12770

Conversation

John-Qiao
Copy link
Member

@John-Qiao John-Qiao commented Jan 13, 2025

Related #10773

Proposed changes

  • Add unit test ListControlUnboundActionListTests.cs for public properties and methods of the ListControlUnboundActionList.
  • Enable nullability in ListControlUnboundActionListTests.cs.
Microsoft Reviewers: Open in CodeFlow

@John-Qiao John-Qiao requested a review from a team as a code owner January 13, 2025 09:56
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.02413%. Comparing base (084e6d0) to head (d39f997).
Report is 68 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                  @@
##                main      #12770          +/-   ##
====================================================
+ Coverage   76.03186%   97.02413%   +20.99227%     
====================================================
  Files           3181        1200        -1981     
  Lines         639670      355930      -283740     
  Branches       47215        5463       -41752     
====================================================
- Hits          486353      345338      -141015     
+ Misses        149797        9783      -140014     
+ Partials        3520         809        -2711     
Flag Coverage Δ
Debug 97.02413% <100.00000%> (+20.99227%) ⬆️
integration ?
production ?
test 97.02413% <100.00000%> (-0.00503%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@John-Qiao John-Qiao added the waiting-review This item is waiting on review by one or more members of team label Jan 15, 2025
Copy link
Member

@Epica3055 Epica3055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@dotnet-policy-service dotnet-policy-service bot added the 📭 waiting-author-feedback The team requires more information from the author label Jan 16, 2025
@ricardobossan ricardobossan removed the waiting-review This item is waiting on review by one or more members of team label Jan 16, 2025
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Jan 16, 2025
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik merged commit 4055829 into dotnet:main Jan 16, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants