Prepare release: v1.0.0 #2676
Prepare release: v1.0.0 #2676
Conversation
WalkthroughOhayo, sensei! This pull request introduces updates to various Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Outside diff range and nitpick comments (1)
Cargo.toml (1)
Ohayo! Time to upgrade cairo-vm, sensei! 🚀
The
cairo-vm = "1.0.0-rc4"dependency is outdated. A stable version1.0.1is now available on crates.io. Consider upgrading to avoid any pre-release quirks!
- Update the dependency in
Cargo.toml:cairo-vm = "1.0.1"🔗 Analysis chain
Line range hint
1-300: Verify dependency version compatibility, sensei!I noticed that some dependencies are still using pre-release versions:
cairo-vm = "1.0.0-rc4"Consider:
- Evaluating if stable versions are available for these dependencies
- Documenting any known compatibility issues with pre-release dependencies
Let's check for any available updates:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for newer versions of dependencies # Expected: Identify if stable versions are available # Search for RC/beta/alpha versions in dependencies rg "(rc|alpha|beta)" Cargo.tomlLength of output: 56
Script:
#!/bin/bash # Let's check if there's a newer version of cairo-vm available curl -s https://crates.io/api/v1/crates/cairo-vm | jq -r '.versions[] | .num' | head -n 5 # Also check if this specific version is mentioned in any documentation rg -l "1\.0\.0-rc4" . --type mdLength of output: 167
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
⛔ Files ignored due to path filters (4)
Cargo.lockis excluded by!**/*.lockcrates/dojo/core/Scarb.lockis excluded by!**/*.lockcrates/torii/types-test/Scarb.lockis excluded by!**/*.lockexamples/spawn-and-move/Scarb.lockis excluded by!**/*.lock
📒 Files selected for processing (4)
Cargo.toml(1 hunks)crates/dojo/core/Scarb.toml(1 hunks)crates/torii/types-test/Scarb.toml(1 hunks)examples/spawn-and-move/Scarb.toml(1 hunks)
🔇 Additional comments (4)
crates/torii/types-test/Scarb.toml (1)
Line range hint 11-11: Verify dojo core dependency alignment
The local path dependency to dojo core and external contract build configuration look good. However, let's ensure the dojo core package is also updated to the stable version.
#!/bin/bash
# Description: Verify dojo core package version
# Expected: dojo core should also be at version 1.0.0
echo "Checking dojo core version..."
cat crates/dojo/core/Scarb.toml | grep "version = "Also applies to: 14-14
crates/dojo/core/Scarb.toml (1)
6-6: Ohayo sensei! Version bump to 1.0.0 looks good! 🎉
The transition from release candidate (1.0.0-rc.0) to stable release (1.0.0) follows semantic versioning conventions.
examples/spawn-and-move/Scarb.toml (1)
6-7: Please verify edition compatibility, sensei!
The edition "2024_07" seems to target a future release. Please confirm this edition is compatible with cairo-version 2.8.4.
Let's check for any documentation or references about this edition:
#!/bin/bash
# Description: Search for documentation about the 2024_07 edition
echo "Searching for edition documentation..."
rg -i "2024_07|edition.*2024" --type mdCargo.toml (1)
58-58: Ohayo sensei! Congratulations on reaching v1.0.0! 🎉
The transition from release candidate (1.0.0-rc.2) to stable version (1.0.0) marks a significant milestone. This change aligns with the PR objective of preparing for the v1.0.0 release.
Let's verify version consistency across the workspace:
✅ Verification successful
Ohayo sensei! Version consistency looks perfect! ✨
The workspace is properly configured with version = "1.0.0" in the root Cargo.toml, and all member crates are using version.workspace = true or don't override the workspace version. This ensures consistent versioning across the entire project for the v1.0.0 release.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check version consistency across workspace
# Expected: All Cargo.toml files should use version 1.0.0
# Search for version fields in all Cargo.toml files
fd "Cargo.toml" | xargs rg "^version\s*=" -A 1
Length of output: 87
Script:
#!/bin/bash
# Let's check versions in workspace members' Cargo.toml files
# First, extract workspace members from root Cargo.toml
rg "members\s*=\s*\[" -A 10 Cargo.toml | rg '".+"' -o | tr -d '"' | while read -r member; do
if [ -f "${member}/Cargo.toml" ]; then
echo "=== ${member}/Cargo.toml ==="
rg "^version\s*=" "${member}/Cargo.toml" || true
fi
done
# Also check package name and version in workspace members
rg "^\[package\]" -A 3 -g "Cargo.toml" --no-filename
Length of output: 7567
Script:
#!/bin/bash
# Let's check workspace version configuration in root Cargo.toml
rg '^\[workspace\]' -A 20 Cargo.toml
# And check if any package has an explicit version that might override workspace
rg '^version\s*=\s*"[^"]*"' -g "Cargo.toml" --no-filename
Length of output: 523
| @@ -2,7 +2,7 @@ | |||
| cairo-version = "=2.8.4" | |||
| edition = "2024_07" | |||
| name = "types_test" | |||
| version = "1.0.0-rc.0" | |||
| version = "1.0.0" | |||
There was a problem hiding this comment.
💡 Codebase verification
Ohayo! Version mismatch detected across packages, sensei!
The version update to "1.0.0" in crates/torii/types-test/Scarb.toml needs alignment with related core packages. Found inconsistencies:
crates/benches/contracts/Scarb.tomlstill at "1.0.0-rc.0"crates/dojo/core-cairo-test/Scarb.tomlstill at "1.0.0-rc.0"- Several example packages are at different versions (0.1.0)
While the core package (crates/dojo/core/Scarb.toml) is correctly at "1.0.0", its test dependencies haven't been updated. Cairo version is consistently set to "2.8.4" across relevant packages.
🔗 Analysis chain
Ohayo! LGTM on the version update, sensei!
The version update from "1.0.0-rc.0" to "1.0.0" aligns with the release preparation objectives.
Let's verify the version alignment across related packages:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check version consistency across Scarb.toml files
# Expected: All related packages should be updated to 1.0.0
echo "Checking version consistency across Scarb.toml files..."
fd -e toml -x grep -H "version = " {}
Length of output: 274
Script:
#!/bin/bash
# Let's try a more reliable approach to find and check versions
echo "Checking all Scarb.toml files and their versions..."
find . -name "Scarb.toml" -type f -exec sh -c 'echo "=== $1 ==="; cat "$1" | grep -E "^version = "' sh {} \;
echo -e "\nChecking cairo versions..."
find . -name "Scarb.toml" -type f -exec sh -c 'echo "=== $1 ==="; cat "$1" | grep -E "cairo-version = "' sh {} \;
Length of output: 2130
| @@ -3,7 +3,7 @@ cairo-version = "=2.8.4" | |||
| edition = "2024_07" | |||
| description = "The Dojo Core library for autonomous worlds." | |||
| name = "dojo" | |||
| version = "1.0.0-rc.0" | |||
| version = "1.0.0" | |||
There was a problem hiding this comment.
💡 Codebase verification
Version inconsistencies detected across Scarb.toml files
Ohayo sensei! I found several inconsistencies in version numbers across Scarb.toml files:
- Some files use version "1.0.0"
- Others use "0.3.1-rc7"
- Several use "0.1.0"
- A couple use "1.0.0-rc.0"
These inconsistencies should be addressed to maintain version alignment across the project. Please update all Scarb.toml files to use version "1.0.0" to match the target version.
🔗 Analysis chain
Verify version consistency across the project.
Let's ensure all related files are updated to the same version.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check version consistency across Cargo.toml and Scarb.toml files
# Expected: All versions should be "1.0.0"
echo "Checking Cargo.toml versions..."
rg -g 'Cargo.toml' 'version\s*=\s*"[^"]*"' --no-filename
echo -e "\nChecking Scarb.toml versions..."
rg -g 'Scarb.toml' 'version\s*=\s*"[^"]*"' --no-filename
Length of output: 4114
| @@ -1,7 +1,7 @@ | |||
| [package] | |||
| cairo-version = "=2.8.4" | |||
| name = "dojo_examples" | |||
| version = "1.0.0-rc.0" | |||
| version = "1.0.0" | |||
There was a problem hiding this comment.
💡 Codebase verification
Ohayo! Version inconsistency detected, sensei!
The version update to 1.0.0 in examples/spawn-and-move/Scarb.toml needs attention as we found mixed versions across the codebase:
- Some packages are still at
1.0.0-rc.0(e.g., crates/dojo/core-cairo-test, crates/benches/contracts) - Core packages have different versions (core: 1.0.0, core-cairo-test: 1.0.0-rc.0)
- Workspace packages are using
0.1.0
Please ensure all related packages are updated consistently to avoid potential compatibility issues.
🔗 Analysis chain
Ohayo! Version update to 1.0.0 looks good, sensei!
The transition from RC to stable version aligns with the release preparation.
Let's verify version consistency across the workspace:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check if all Scarb.toml files are updated to version 1.0.0
echo "Checking version consistency across Scarb.toml files..."
fd -e toml -x grep -l "version = " {} \; | xargs grep "version = "
Length of output: 256
Script:
#!/bin/bash
# Let's try a different approach to find Scarb.toml files and their versions
echo "Searching for all Scarb.toml files..."
fd "Scarb.toml" --type f -x cat {}
# Also search for any version-related patterns in the codebase
echo -e "\nSearching for version patterns in Scarb.toml files..."
rg "version\s*=\s*['\"]1\.0\.0" --type toml
Length of output: 6293
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2676 +/- ##
==========================================
+ Coverage 57.59% 57.60% +0.01%
==========================================
Files 404 404
Lines 51101 51101
==========================================
+ Hits 29431 29437 +6
+ Misses 21670 21664 -6 ☔ View full report in Codecov by Sentry. |
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
New Features
1.0.0, enhancing stability and reliability.dojo_examplespackage to"2024_07".Bug Fixes