Prepare release: v1.0.7 #2804
Prepare release: v1.0.7 #2804
Conversation
WalkthroughOhayo, sensei! This pull request updates the version numbers across multiple Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
Cargo.toml (1)
Ohayo! Version mismatch requires attention, sensei!
The verification reveals a significant version disparity that needs addressing:
- Current alloy ecosystem packages (0.8.0+) are several major versions ahead of what's being used (0.3)
- alloy-primitives and alloy-sol-types (0.8.3) are using a different major version than other alloy packages (0.3)
- Latest stable versions (0.8.15/0.8.0) are available for all packages
This version mismatch across the alloy ecosystem could lead to compatibility issues. Consider:
- Upgrading all alloy packages to the latest 0.8.x versions
- At minimum, aligning all packages to use the same major version
🔗 Analysis chain
Line range hint
249-250: Verify alloy ecosystem dependencies version consistencyOhayo sensei! I notice we're using two different version sets for alloy packages:
- alloy-primitives and alloy-sol-types: v0.8.3
- Other alloy-* packages: v0.3
While this might be intentional, it's worth verifying the compatibility between these versions.
Also applies to: 264-270
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for compatibility issues between alloy packages # Check if these versions are the latest stable releases for pkg in alloy-primitives alloy-sol-types alloy-contract alloy-json-rpc alloy-network alloy-provider alloy-rpc-types-eth alloy-signer alloy-transport; do echo "Checking $pkg..." curl -s "https://crates.io/api/v1/crates/$pkg" | jq -r '.crate.max_stable_version' done # Check for any reported issues about version mismatches gh api graphql -f query=' { search(query: "repo:alloy-rs/alloy is:issue state:open version compatibility", type: ISSUE, first: 5) { nodes { ... on Issue { title url labels(first: 5) { nodes { name } } } } } }'Length of output: 3178
Script:
#!/bin/bash # Let's check the actual versions used in Cargo.toml rg "alloy-" -A 1 Cargo.tomlLength of output: 609
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (4)
Cargo.lockis excluded by!**/*.lockcrates/dojo/core/Scarb.lockis excluded by!**/*.lockcrates/torii/types-test/Scarb.lockis excluded by!**/*.lockexamples/spawn-and-move/Scarb.lockis excluded by!**/*.lock
📒 Files selected for processing (4)
Cargo.toml(1 hunks)crates/dojo/core/Scarb.toml(1 hunks)crates/torii/types-test/Scarb.toml(1 hunks)examples/spawn-and-move/Scarb.toml(1 hunks)
✅ Files skipped from review due to trivial changes (3)
- crates/dojo/core/Scarb.toml
- crates/torii/types-test/Scarb.toml
- examples/spawn-and-move/Scarb.toml
🔇 Additional comments (2)
Cargo.toml (2)
63-63: LGTM: Version bump for release v1.0.7
Ohayo sensei! The version update from 1.0.6 to 1.0.7 aligns with the PR objectives and matches the version updates in other configuration files.
Line range hint 249-250: Verify impact of disabled default features
Ohayo sensei! All new alloy dependencies have default-features = false. Let's verify that all necessary features are still available through other means or explicit feature selections.
Also applies to: 264-270
✅ Verification successful
Ohayo! Features are properly configured, no issues found
From the previous search results, I can see that while default features are disabled in the workspace dependencies, each crate explicitly enables the features it needs:
primitivescrate usesarbitraryandserdefeaturesrpccrate enables comprehensive features:contract,network,node-bindings,provider-http,providers,signer-local, andserdecorecrate carefully selects required features likejson,reqwest,reqwest-rustls-tls, andserde
This is actually a good practice as it makes the feature selection explicit and prevents pulling in unnecessary dependencies.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check default features that are being disabled
# Search for feature-related configurations in the codebase
rg -A 5 'features.*alloy'
# List Cargo.toml files that might have explicit feature selections
fd -e toml | xargs rg 'alloy-.*features'
Length of output: 1870
Script:
#!/bin/bash
# Let's check the default features of these alloy crates to understand what we're disabling
rg -A 10 '\[features\]' Cargo.toml
# Also check workspace features
rg 'workspace.features' -A 10 Cargo.toml
# And check if there are any feature-related comments that might explain the choices
rg '(?i)feature.*alloy' -A 5
Length of output: 108
|
Waiting addition of @Larkooo for the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2804 +/- ##
=======================================
Coverage 55.74% 55.75%
=======================================
Files 439 439
Lines 55572 55572
=======================================
+ Hits 30981 30982 +1
+ Misses 24591 24590 -1 ☔ View full report in Codecov by Sentry. |
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
New Features
Bug Fixes